Skip to content

[WIP] Clarify flush logic in code comments#32871

Closed
Copilot wants to merge 1 commit into26_1from
copilot/explain-flush-logic-in-comments
Closed

[WIP] Clarify flush logic in code comments#32871
Copilot wants to merge 1 commit into26_1from
copilot/explain-flush-logic-in-comments

Conversation

Copy link
Contributor

Copilot AI commented Mar 11, 2026

  • Fix translator.ts: guard offsetHeight layout flush with element existence check instead of removing it entirely
  • Fix m_position.ts: add early return when $what.length is 0 to prevent crash
  • Create translator.test.ts: tests for resetPosition (no-throw with empty/missing element, flush preserved for real elements)
  • Create m_position.test.ts: tests for positionUtils.setup including setup(what, options) with non-existent element

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants