-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Implement AppLifecycleService and refactor to fix auto updater
#530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
charlesvien
merged 4 commits into
main
from
01-16-implement_applifecycleservice_and_refactor_to_fix_auto_updater
Jan 21, 2026
Merged
feat: Implement AppLifecycleService and refactor to fix auto updater
#530
charlesvien
merged 4 commits into
main
from
01-16-implement_applifecycleservice_and_refactor_to_fix_auto_updater
Jan 21, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
AppLifecycleService and refactor to fix auto updater
4d88993 to
3bde2b0
Compare
This was referenced Jan 17, 2026
4d87684 to
feb4482
Compare
Base automatically changed from
01-17-fix_ci_cd_pipeline_trying_to_double_release_on_commits_to_main
to
main
January 17, 2026 22:51
3bde2b0 to
7b678df
Compare
Base automatically changed from
01-17-configure_the_git_identity_in_the_new_tag_workflow
to
main
January 18, 2026 03:18
7b678df to
97bc3d0
Compare
Contributor
Author
c2295c1 to
da9e88b
Compare
k11kirky
reviewed
Jan 20, 2026
k11kirky
approved these changes
Jan 20, 2026
Contributor
k11kirky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
da9e88b to
7347cf0
Compare
This was referenced Jan 21, 2026
Contributor
Author
|
This should also address "Point 5: Manual Update Issue" on the Array Feedback PDF |
Contributor
Author
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Alright here's what I found in the cave...
the bug: when
autoUpdater.quitAndInstall()was invoked, it triggered thebefore-quitevent, but the handler would intercept it, prevent the default behavior, and forcibly exit the app before the updater could complete its installation flow.solution: this PR introduces a new
AppLifecycleServicethat centralizes all shutdown logic and tracks anisQuittingForUpdateflag. Now when installing an update, theUpdatesServicefirst callslifecycleService.shutdown()to gracefully clean up, then setslifecycleService.setQuittingForUpdate()before callingquitAndInstall(). Thebefore-quithandler now checks this flag and returns early if set, allowing the auto updater to proceed unblocked. This separates the "normal quit with cleanup" path from the "quit for update" pathNOTE: There is a different event sequence for
quitAndInstall()Excerpt taken from electron docs
The Event Sequence for
quitAndInstall()Normal quit:
before-quitemittedcloseeventswill-quitemittedquitAndInstall()sequence (different!):closeevents firstbefore-quitemitted after windows are closed