GH-301: [Vector] Allow adding a vector at the end of VectorSchemaRoot#1013
GH-301: [Vector] Allow adding a vector at the end of VectorSchemaRoot#1013axreldable wants to merge 1 commit intoapache:mainfrom
Conversation
axreldable
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
This comment has been minimized.
This comment has been minimized.
|
I'd say it's an |
lidavidm
added
enhancement
axreldable
force-pushed
the
add-vector-to-end
branch
from
1d9a7eb to
0037d11
Compare
|
@axreldable can you please rebase this PR ? The CI should be triggered and clean. |
axreldable
force-pushed
the
add-vector-to-end
branch
from
0037d11 to
c76ebd3
Compare
@jbonofre , rebased, but looks like it needs to be kicked off. It's not triggered automatically. Could you help with it? |
Hi @jbonofre ! The build was successful. Should I rebase again after the latest changes? |
ennuite
left a comment
ennuite
left a comment
There was a problem hiding this comment.
lgtm, it's the same code as the issue report
|
@jbonofre , what do you think about this change? |
axreldable
changed the title
4 participants
What's Changed
Allow adding a vector at the end of VectorSchemaRoot in the
VectorSchemaRoot#addVector()method.Previously, the precondition
index < fieldVectors.size()rejectedindex == fieldVectors.size(), so appending was impossible. The precondition is nowindex <= fieldVectors.size(), and whenindex == fieldVectors.size()the new vector is appended after all existing vectors.The implementation of
VectorSchemaRoot#addVector()is now aligned with BaseTable#insertVector()The change is backward compatible, as it extends the functionality of the
VectorSchemaRoot#addVector()method.Closes #301.