From d4f0bb433d96b3543159c79b701166c6da28783a Mon Sep 17 00:00:00 2001 From: Bruno Melo Date: Thu, 3 Apr 2025 15:09:54 -0300 Subject: [PATCH] Fix: Warn about SSL Certificate verification being disabled only when it's actually disabled Only Boolean.TRUE disables SSL Certificate Validation, so both Boolean.FALSE and null should skip the warning message --- .../services/s3/internal/crt/S3NativeClientConfiguration.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/crt/S3NativeClientConfiguration.java b/services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/crt/S3NativeClientConfiguration.java index 4925a708c818..56c79c721a30 100644 --- a/services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/crt/S3NativeClientConfiguration.java +++ b/services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/crt/S3NativeClientConfiguration.java @@ -74,7 +74,7 @@ public S3NativeClientConfiguration(Builder builder) { .withCipherPreference(TlsCipherPreference.TLS_CIPHER_SYSTEM_DEFAULT); if (builder.httpConfiguration != null - && builder.httpConfiguration.trustAllCertificatesEnabled() != null) { + && Boolean.TRUE.equals(builder.httpConfiguration.trustAllCertificatesEnabled())) { log.warn(() -> "SSL Certificate verification is disabled. " + "This is not a safe setting and should only be used for testing."); clientTlsContextOptions.withVerifyPeer(!builder.httpConfiguration.trustAllCertificatesEnabled());