Wrong Gazelle mappings after upgrading to 1.8

[psalaberria002]

We are seeing a wrong change for a specific dependency in gazelle_python.yaml after upgrading the Gazelle plugin from 1.6 to 1.8.1.

# requirements.in
bosdyn-client==5.0.1.2
bosdyn-orbit==5.0.1.2

Build error:

E   ModuleNotFoundError: No module named 'bosdyn.client'

I suspect it was introduced by https://github.com/bazel-contrib/rules_python/pull/3415/changes

Adding manual resolve directives solves the build errors, but that's just a workaround.

# gazelle:resolve py bosdyn.api @python_deps//bosdyn_api
# gazelle:resolve py bosdyn.bddf @python_deps//bosdyn_core
# gazelle:resolve py bosdyn.client @python_deps//bosdyn_client
# gazelle:resolve py bosdyn.deprecated @python_deps//bosdyn_core
# gazelle:resolve py bosdyn.geometry @python_deps//bosdyn_core
# gazelle:resolve py bosdyn.util @python_deps//bosdyn_core

[aignas]

Does it work if you keep gazelle plugin at 1.6 but rules_python at 1.8.1?

[psalaberria002]

Does it work if you keep gazelle plugin at 1.6 but rules_python at 1.8.1?

Yes, it does. We managed to update rules_python to 1.8.1 independently. No diff in the gazelle_python.yaml

[aignas]

What about 1.8.1 plugin version and 1.8.1 rules_python version? There was a bug in how dependencies are resolved with 1.8.1 and I would like to exclude this possibility.

[psalaberria002]

What about 1.8.1 plugin version and 1.8.1 rules_python version? There was a bug in how dependencies are resolved with 1.8.1 and I would like to exclude this possibility.

That's the combination I tried initially, and it failed.

The only combination I haven't tried is gazelle plugin 1.8.1, and older rules_python.

[aignas]

If you revert #3415 in gazelle does it work?

To be honest, this is the only recent change that touches this code.

Since older gazelle and latest rules_python works, then it seems to be OK to not try gazelle 1.8.1 and older rules_python.

[aignas]

cc @thejcannon, in case you have any ideas about this.

[arjantop-cai]

Another example with agno and agno_aws:

1.6.1:

    agno: agno_aws
    agno.agent: agno
    agno.api: agno
    agno.cloud.aws.base: agno
    agno.cloud.aws.s3: agno
    agno.compression: agno
    agno.culture: agno
    agno.db: agno
    agno.debug: agno
    agno.eval: agno
    agno.exceptions: agno
    agno.filters: agno
    agno.guardrails: agno
    agno.hooks: agno
    agno.integrations: agno
    agno.knowledge: agno
    agno.media: agno
    agno.memory: agno
    agno.models: agno
    agno.os: agno
    agno.reasoning: agno
    agno.run: agno
    agno.session: agno
    agno.table: agno
    agno.team: agno
    agno.tools: agno
    agno.tracing: agno
    agno.utils: agno
    agno.vectordb: agno
    agno.workflow: agno

1.8.1:

   agno: agno_aws

rules 1.8.1 + gazelle 1.6.1 works
rules 1.8.1 + gazelle 1.8.1 does not work

[thejcannon]

cc @thejcannon, in case you have any ideas about this.

I can try and take a look this weekend (but no promises, we got a winter storm blowing through Texas. It's bad enough our most notable elected official is bravely running away, away).

You're right to suspect the parallel wheel scraping change though! I'm guessing something to do with ordering and namespace packages.