From 283b69b4d0e304e1b82e3f76f3a93510f31ffb2b Mon Sep 17 00:00:00 2001 From: garvitssoni Date: Tue, 7 Apr 2026 15:49:13 +0530 Subject: [PATCH 1/3] fix: handle provider status default cases across providers --- v1/providers/fluidstack/instance.go | 2 +- v1/providers/lambdalabs/instance.go | 2 +- v1/providers/nebius/instance.go | 2 +- v1/providers/sfcompute/instance.go | 2 +- v1/providers/shadeform/instance.go | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/v1/providers/fluidstack/instance.go b/v1/providers/fluidstack/instance.go index 6e5e9c2c..22c43462 100644 --- a/v1/providers/fluidstack/instance.go +++ b/v1/providers/fluidstack/instance.go @@ -131,7 +131,7 @@ func convertFluidStackInstanceToV1Instance(fsInstance openapi.Instance) *v1.Inst case openapi.INSTANCE_ERROR: lifecycleStatus = v1.LifecycleStatusFailed default: - lifecycleStatus = v1.LifecycleStatusPending + lifecycleStatus = "" } instance := &v1.Instance{ diff --git a/v1/providers/lambdalabs/instance.go b/v1/providers/lambdalabs/instance.go index c47d5033..7ba7b832 100644 --- a/v1/providers/lambdalabs/instance.go +++ b/v1/providers/lambdalabs/instance.go @@ -217,7 +217,7 @@ func convertLambdaLabsStatusToV1Status(status string) v1.LifecycleStatus { case "unhealthy": return v1.LifecycleStatusRunning default: - return v1.LifecycleStatusPending + return "" } } diff --git a/v1/providers/nebius/instance.go b/v1/providers/nebius/instance.go index 7b126ff7..ffcf48fb 100644 --- a/v1/providers/nebius/instance.go +++ b/v1/providers/nebius/instance.go @@ -247,7 +247,7 @@ func (c *NebiusClient) convertNebiusInstanceToV1(ctx context.Context, instance * case compute.InstanceStatus_ERROR: lifecycleStatus = v1.LifecycleStatusFailed default: - lifecycleStatus = v1.LifecycleStatusFailed + lifecycleStatus = "" } } else { lifecycleStatus = v1.LifecycleStatusFailed diff --git a/v1/providers/sfcompute/instance.go b/v1/providers/sfcompute/instance.go index dfaf2447..c8124510 100644 --- a/v1/providers/sfcompute/instance.go +++ b/v1/providers/sfcompute/instance.go @@ -415,7 +415,7 @@ func sfcStatusToLifecycleStatus(status string) v1.LifecycleStatus { case "nodefailure", "failed": return v1.LifecycleStatusFailed default: - return v1.LifecycleStatusPending + return "" } } diff --git a/v1/providers/shadeform/instance.go b/v1/providers/shadeform/instance.go index 372a9fb5..356e1fd4 100644 --- a/v1/providers/shadeform/instance.go +++ b/v1/providers/shadeform/instance.go @@ -291,7 +291,7 @@ func (c *ShadeformClient) getLifecycleStatus(status string) v1.LifecycleStatus { case "error": lifecycleStatus = v1.LifecycleStatusFailed default: - lifecycleStatus = v1.LifecycleStatusPending + lifecycleStatus = "" } return lifecycleStatus } From 37f6b33ca550f1363d157499e02a20403e867d29 Mon Sep 17 00:00:00 2001 From: garvitssoni Date: Tue, 7 Apr 2026 17:08:40 +0530 Subject: [PATCH 2/3] fix: handle provider status default cases across providers --- v1/instance.go | 1 + v1/providers/lambdalabs/instance.go | 2 +- v1/providers/nebius/instance.go | 2 +- v1/providers/sfcompute/instance.go | 2 +- 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/v1/instance.go b/v1/instance.go index cb10640d..0a40bad1 100644 --- a/v1/instance.go +++ b/v1/instance.go @@ -112,6 +112,7 @@ const ( LifecycleStatusTerminating LifecycleStatus = "terminating" LifecycleStatusTerminated LifecycleStatus = "terminated" LifecycleStatusFailed LifecycleStatus = "failed" + LifecycleStatusEmpty LifecycleStatus = "" ) const ( diff --git a/v1/providers/lambdalabs/instance.go b/v1/providers/lambdalabs/instance.go index 7ba7b832..8712f91b 100644 --- a/v1/providers/lambdalabs/instance.go +++ b/v1/providers/lambdalabs/instance.go @@ -217,7 +217,7 @@ func convertLambdaLabsStatusToV1Status(status string) v1.LifecycleStatus { case "unhealthy": return v1.LifecycleStatusRunning default: - return "" + return v1.LifecycleStatusEmpty } } diff --git a/v1/providers/nebius/instance.go b/v1/providers/nebius/instance.go index ffcf48fb..6831e8ef 100644 --- a/v1/providers/nebius/instance.go +++ b/v1/providers/nebius/instance.go @@ -247,7 +247,7 @@ func (c *NebiusClient) convertNebiusInstanceToV1(ctx context.Context, instance * case compute.InstanceStatus_ERROR: lifecycleStatus = v1.LifecycleStatusFailed default: - lifecycleStatus = "" + lifecycleStatus = v1.LifecycleStatusEmpty } } else { lifecycleStatus = v1.LifecycleStatusFailed diff --git a/v1/providers/sfcompute/instance.go b/v1/providers/sfcompute/instance.go index c8124510..bfd4cd07 100644 --- a/v1/providers/sfcompute/instance.go +++ b/v1/providers/sfcompute/instance.go @@ -415,7 +415,7 @@ func sfcStatusToLifecycleStatus(status string) v1.LifecycleStatus { case "nodefailure", "failed": return v1.LifecycleStatusFailed default: - return "" + return v1.LifecycleStatusEmpty } } From 464b0c3fdbca05a6106d27a075278be1037862fe Mon Sep 17 00:00:00 2001 From: garvitssoni Date: Tue, 7 Apr 2026 17:26:33 +0530 Subject: [PATCH 3/3] fix: handle provider status default cases across providers --- v1/instance.go | 2 +- v1/providers/fluidstack/instance.go | 2 +- v1/providers/shadeform/instance.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/v1/instance.go b/v1/instance.go index 0a40bad1..cd34de88 100644 --- a/v1/instance.go +++ b/v1/instance.go @@ -112,7 +112,7 @@ const ( LifecycleStatusTerminating LifecycleStatus = "terminating" LifecycleStatusTerminated LifecycleStatus = "terminated" LifecycleStatusFailed LifecycleStatus = "failed" - LifecycleStatusEmpty LifecycleStatus = "" + LifecycleStatusEmpty LifecycleStatus = "" ) const ( diff --git a/v1/providers/fluidstack/instance.go b/v1/providers/fluidstack/instance.go index 22c43462..0a79a38f 100644 --- a/v1/providers/fluidstack/instance.go +++ b/v1/providers/fluidstack/instance.go @@ -131,7 +131,7 @@ func convertFluidStackInstanceToV1Instance(fsInstance openapi.Instance) *v1.Inst case openapi.INSTANCE_ERROR: lifecycleStatus = v1.LifecycleStatusFailed default: - lifecycleStatus = "" + lifecycleStatus = v1.LifecycleStatusEmpty } instance := &v1.Instance{ diff --git a/v1/providers/shadeform/instance.go b/v1/providers/shadeform/instance.go index 356e1fd4..3683d8b6 100644 --- a/v1/providers/shadeform/instance.go +++ b/v1/providers/shadeform/instance.go @@ -291,7 +291,7 @@ func (c *ShadeformClient) getLifecycleStatus(status string) v1.LifecycleStatus { case "error": lifecycleStatus = v1.LifecycleStatusFailed default: - lifecycleStatus = "" + lifecycleStatus = v1.LifecycleStatusEmpty } return lifecycleStatus }