Move pytest warning enable into pyproject.toml #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wasn't sure on the syntax for this before, so just went with the CLI invocation. I think we just want this (by default) on any `pytest` invocation. Signed-off-by: Stefan VanBuren <[email protected]>
stefanvanburen
added a commit
to bufbuild/protovalidate-python
that referenced
this pull request
Feb 5, 2026
Just a ratchet to ensure we don't inadvertently miss warnings in CI output. Similar to connect-python: connectrpc/connect-python#118
Member
Author
|
hm, wasn't expecting this to fail. maybe related: pytest-dev/pytest#14096? |
Member
Author
|
(and doesn't fail locally 😞) |
stefanvanburen
added a commit
to bufbuild/protovalidate-python
that referenced
this pull request
Feb 5, 2026
Just a ratchet to ensure we don't inadvertently miss warnings in CI output. Similar to connect-python: connectrpc/connect-python#118
Collaborator
|
Doh - I think that's a linux-only codepath being used by pyvoy once on startup. Sent a fix to the library, will see if that can be updated soon enough or if I'll need to vendor it to fix that. |
Member
Author
|
no worries on a quick fix, we can always hold off on landing this on our end, it's a minor thing. |
stefanvanburen
added a commit
to stefanvanburen/pyvoy
that referenced
this pull request
Feb 11, 2026
To pull in ktbarrett/find_libpython#111, for connectrpc/connect-python#118. via `uv lock --upgrade-package find-libpython`.
Signed-off-by: Anuraag Agrawal <[email protected]>
anuraaga
force-pushed
the
svanburen/pytest-warnings-pyproject-toml
branch
from
61fc677 to
3a0127b
Compare
anuraaga
approved these changes
Feb 12, 2026
Collaborator
|
Thanks for teaching me these practices! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasn't sure on the syntax for this before, so just went with the CLI invocation. I think we just want this (by default) on any
pytestinvocation.