Malformed request line

[new-user-name]

Deployer Version

8.0

Target OS

Windows 11

Which PHP version are you using?

PHP 8.4

Content of deploy.php or deploy.yaml

<?php

namespace Deployer;

require 'recipe/laravel.php';
require 'contrib/rsync.php';

host('14.89.89.14')
    ->set('remote_user', 'root')
    ->set('deploy_path', '/var/www/ftl')
    ->set('rsync_src', '/c/php/cargo2')
    ->set('rsync_dest','/var/www/ftl');

set('application', 'Hippo.Market');

set('composer_options', '--verbose --prefer-dist --no-progress --no-interaction --no-dev --optimize-autoloader --apcu-autoloader --no-scripts');

after('deploy:failed', 'deploy:unlock');

set('ssh_multiplexing', false);

set('rsync', [
    'exclude' => [
        '.git',
        '.DS_Store',
        '.idea',
        'deploy.php',
        'node_modules',
        'vendor',
        'var',
        '.env.local',
        '.env.*.local',
        'tests',
        '.php_cs.dist',
        'docker-compose.yml',
        'docker-compose.override.yml',
        'phpstan.neon',
        'phpunit.xml.dist',
        'package.json',
        'postcss.config.js',
        'tailwind.config.js',
        'webpack.config.js',
        'yarn.lock',
        '.php-version',
    ],
    // defaults see: https://github.com/deployphp/deployer/issues/2890
    'exclude-file' => false,
    'include' => [],
    'include-file' => false,
    'filter' => [],
    'filter-file' => false,
    'filter-perdir' => false,
    'flags' => 'rz', // Recursive, with compress
    'options' => ["delete"],
]);

task('deploy:update_code')->disable();
after('deploy:update_code', 'rsync');

Steps to reproduce

vendor/bin/dep rsync
from Windows 11 to Ubuntu 24, Malformed request line error in console, Server.php, line 167.
This gives empty line

 $lines = explode("\r\n", $request);
 $requestLine = $lines[0];
 $parts = explode(' ', $requestLine);
 if (count($parts) !== 3) {
      $this->output->writeln($requestLine);
      throw new Exception("Malformed request line: $requestLine");
  }

[Muffinman]

I get this error frequently in our Gitlab CI pipelines (seemingly at random) and it's extremely annoying.

There seems to be no pattern to it, and re-running the same identical pipeline always works the second time.

I get the same error on a variety of projects and deployment targets so really think the issue must be internal to deployer somewhere.

<?php

namespace Deployer;

use Illuminate\Support\Facades\Http;

require 'recipe/laravel.php';

// Config

set('repository', 'git@gitlab.example.com:super-secret-project.git');
set('gitlab_project_id', 123);
set('chat_webhook', 'https://chat.googleapis.com/v1/spaces/SPACEID');

add('shared_dirs', [
    'storage',
    'docker',
]);

// Hosts

host('staging')
    ->setDeployPath('~/staging')
    ->setHostname('example.com')
    ->setRemoteUser('staging')
    ->setSshArguments([
        '-o StrictHostKeyChecking=accept-new',
    ])
    ->set('branch', 'develop')
    ->set('php_version', 8.4)
    ->set('identity_file', fn () => $_ENV['DEPLOY_PRIVATE_KEY'] ?? '');

host('live')
    ->setDeployPath('~/production')
    ->setHostname('example.com')
    ->setRemoteUser('production')
    ->setSshArguments([
        '-o StrictHostKeyChecking=accept-new',
    ])
    ->set('branch', 'main')
    ->set('php_version', 8.4)
    ->set('identity_file', fn () => $_ENV['DEPLOY_PRIVATE_KEY'] ?? '');

// Hooks

after('deploy:symlink', 'artisan:horizon:terminate');
after('deploy:symlink', 'docs:build');
after('deploy:failed', 'deploy:unlock');

// Tasks

task('artisan:landlord:migrate', artisan('migrate --force --path=database/migrations/landlord --database=landlord', ['skipIfNoEnv']));
task('artisan:tenant:migrate', artisan('tenants:artisan "migrate --force"', ['skipIfNoEnv']));
task('artisan:tenant:optimize', artisan('tenants:artisan "optimize"', ['skipIfNoEnv']));

task('npm:build', function () {
    $commands = [
        'cd {{release_path}}',
        'export NVM_DIR="$HOME/.nvm"',
        '[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"',
        'nvm install --lts',
        'nvm use --lts',
        'npm install',
        'npm run build',
        'rm -rf node_modules',
    ];
    run(implode(' && ', $commands));
});

task('docs:build', function () {
    $commands = [
        'cd {{release_path}}',
        '{{bin/php}} {{bin/artisan}} tenants:artisan "scribe:generate" --tenant=1',
    ];
    run(implode(' && ', $commands));
});

task('notify:chat', function () {
    if (! get('gitlab_project_id') || ! get('chat_webhook')) {
        return;
    }
    $revision = run('cd {{release_path}} && cat REVISION');
    Http::post('https://example.com/api/deployment-notification', [
        'commit_project_id' => get('gitlab_project_id'),
        'commit_sha' => $revision,
        'chat_webhook' => get('chat_webhook'),
    ]);
})->select('live');

task('deploy', [
    'deploy:prepare',
    'deploy:vendors',
    'artisan:storage:link',
    'npm:build',
    'artisan:landlord:migrate',
    'artisan:tenant:migrate',
    'artisan:optimize:clear',
    'artisan:tenant:optimize',
    'deploy:publish',
    'notify:chat',
]);

In this case the exception happened immediately after horizon:terminate is called. However this also happens on projects with no Horizon installed.

artisan:horizon:terminate
[staging] run /usr/bin/php8.4 ~/staging/releases/147/artisan horizon:terminate
[staging]    INFO  Sending TERM signal to processes.  
[staging]   Process: 3310027
[staging] ...............................................
[staging]  0.07ms DONE
In Server.php line 167:
                                  
  [Deployer\Exception\Exception]  
  Malformed request line:         
                                  
Exception trace:
  at /builds/example/vendor/deployer/deployer/src/Executor/Server.php:167
 Deployer\Executor\Server->parseRequest() at /builds/example/vendor/deployer/deployer/src/Executor/Server.php:142
 Deployer\Executor\Server->handleClientRequests() at /builds/example/vendor/deployer/deployer/src/Executor/Server.php:71
 Deployer\Executor\Server->run() at /builds/example/vendor/deployer/deployer/src/Executor/Master.php:230
 Deployer\Executor\Master->runTask() at /builds/example/vendor/deployer/deployer/src/Executor/Master.php:110
 Deployer\Executor\Master->run() at /builds/example/vendor/deployer/deployer/src/Command/MainCommand.php:135
 Deployer\Command\MainCommand->execute() at /builds/example/vendor/symfony/console/Command/Command.php:341
 Symfony\Component\Console\Command\Command->run() at /builds/example/vendor/symfony/console/Application.php:1094
 Symfony\Component\Console\Application->doRunCommand() at /builds/example/vendor/symfony/console/Application.php:356
 Symfony\Component\Console\Application->doRun() at /builds/example/vendor/symfony/console/Application.php:195
 Symfony\Component\Console\Application->run() at /builds/example/vendor/deployer/deployer/src/Deployer.php:289
 Deployer\Deployer::run() at /builds/example/vendor/deployer/deployer/bin/dep:103
 include() at /builds/example/vendor/bin/dep:119
deploy [--tag TAG] [--revision REVISION] [--branch BRANCH] [-o|--option OPTION] [-l|--limit LIMIT] [--no-hooks] [--plan] [--start-from START-FROM] [--log LOG] [--profile PROFILE] [--] [<selector>...]