Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@
- Bump Native SDK from v0.12.3 to v0.12.4 ([#5061](https://github.com/getsentry/sentry-java/pull/5061))
- [changelog](https://github.com/getsentry/sentry-native/blob/master/CHANGELOG.md#0124)
- [diff](https://github.com/getsentry/sentry-native/compare/0.12.3...0.12.4)
- Bump Gradle from v8.14.3 to v9.3.1 ([#5063](https://github.com/getsentry/sentry-java/pull/5063))
- [changelog](https://github.com/gradle/gradle/blob/master/CHANGELOG.md#v931)
- [diff](https://github.com/gradle/gradle/compare/v8.14.3...v9.3.1)

## 8.31.0

Expand Down
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-bin.zip
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The update to Gradle 9.3.1 is incompatible with the project's default Android Gradle Plugin (AGP) version of 8.6.0, which will likely cause build failures.
Severity: HIGH

Suggested Fix

Update the default AGP version in buildSrc/src/main/java/Config.kt to a version compatible with Gradle 9.3.1, such as 8.13.0 or newer. Aligning the default with the versions tested in the CI matrix (e.g., 8.7.0+) would also be a valid approach.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: gradle/wrapper/gradle-wrapper.properties#L3

Potential issue: The pull request upgrades Gradle to version 9.3.1, but the default
Android Gradle Plugin (AGP) version remains 8.6.0 in `buildSrc/src/main/java/Config.kt`.
According to official documentation, Gradle 9.3.1 is tested for compatibility with AGP
versions 8.13 and newer. This mismatch will likely cause build failures in environments
that use the default AGP version, such as the main CI workflow and local developer
builds where the `VERSION_AGP` environment variable is not explicitly set.

Did we get this right? 👍 / 👎 to inform future reviews.

networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
Expand Down
Loading