-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(input-otp): convert to a form associated shadow component #30785 #30884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
54a5e4e
refactor(textarea): convert to a form associated shadow component
brandyscarney 8417741
style: lint
brandyscarney 59b2423
chore: build
brandyscarney 08a90a2
test(textarea): query the shadowRoot in tests
brandyscarney f7e8146
test(angular): add textarea to lazy forms test
brandyscarney 6c7d3fb
test(vue): query textarea by shadow and add validation tests
brandyscarney 1fd0f26
test(react): query textarea by shadow and add validation tests
brandyscarney 3bf9289
test(frameworks): input-otp doesn't support required
brandyscarney 27c18c2
test(react): blur focused element instead of targeting textarea
brandyscarney cd58d35
feat(textarea): expose shadow parts
brandyscarney 391d2f6
test(textarea): add tests for form validation and customizing with parts
brandyscarney a401ba2
test(textarea): fix customizing bottom content css
brandyscarney cab5efa
fix(textarea): update styles due to shadow encapsulation
brandyscarney 4ec7a7f
fix(textarea): update styles due to shadow encapsulation
brandyscarney 0e4dee8
fix(textarea): update element internals on load, value change, disabl…
brandyscarney 3c5a152
fix(textarea): add a check for ElementInternals setFormValue for tests
brandyscarney 0db5da6
Merge branch 'next' into FW-6912-textarea
brandyscarney 7f25e7b
test(popover): add popover examples with inputs and buttons
brandyscarney 5fe0c00
chore(): add updated snapshots
brandyscarney f39a1e3
test(popover): update to grab the textarea in shadow root
brandyscarney ec80920
test(popover): add tests for keyboard interactions on inputs and focu…
brandyscarney a2a584f
fix(utils): fix focus behavior for textareas and buttons in popovers
brandyscarney 903b799
fix(overlays): override tab navigation to skip over host elements
brandyscarney 91a2f74
docs(breaking): add textarea conversion
brandyscarney 4480c7a
Merge branch 'next' into FW-6912-textarea
brandyscarney efef5a1
docs(breaking): move radio group to the right place
brandyscarney 823943d
test(textarea): use shadow part for styling native werapper
brandyscarney 3e724c5
fix(textarea): add box-sizing to fix label border shift
brandyscarney 34e104c
Merge branch 'next' into FW-6912-textarea
brandyscarney bb45463
chore(): add updated snapshots
brandyscarney ab96071
Merge branch 'next' into FW-6912-textarea
brandyscarney 9957376
feat(input-otp): convert to shadow
brandyscarney d316fc3
test(react, vue): fix input reference
brandyscarney 9d14d67
test(textarea): add on to form test for submit and reset
brandyscarney 1d8e95d
fix(textarea): implement formResetCallback to reset forms
brandyscarney b6db94c
style: lint
brandyscarney 9e1fb27
feat(textarea): add wrapper part
brandyscarney 502dfe5
Merge branch 'FW-6912-textarea' into FW-6912-input-otp
brandyscarney d73311a
test(input-otp): add test for customizing shadow parts
brandyscarney a67b85a
test(input-otp): add forms test
brandyscarney 8123b37
feat(input-otp): implement updateElementInternals for forms
brandyscarney 87d636f
test(react, vue): fix typing in input otp tests
brandyscarney 7cd1c5b
docs(breaking): add wrapper part for textarea
brandyscarney ddf9706
Merge branch 'FW-6912-textarea' into FW-6912-input-otp
brandyscarney dbd307e
test(input-otp): add e2e test for form
brandyscarney 957de28
Merge branch 'next' into FW-6912-textarea
brandyscarney f8e9c7a
Merge branch 'FW-6912-textarea' into FW-6912-input-otp
brandyscarney eb323d7
test(input-otp): remove duplicate checks
brandyscarney 7a2a990
test(popover): replace page.keyboard.press with pageUtils.pressKeys
brandyscarney d1d2635
test(textarea): remove duplicate checks
brandyscarney 0aac0dc
fix(textarea): add delegatesFocus to resolve Firefox focus errors
brandyscarney 8ea32da
docs(input-otp): remove required mention
brandyscarney 4e11f32
fix(textarea): restore value when the form state restores
brandyscarney 1fc7cb0
Merge branch 'FW-6912-textarea' into FW-6912-input-otp
brandyscarney 4ddebce
fix(input-otp): restore value when the form state restores
brandyscarney ed1de2d
Merge branch 'next' into FW-6912-input-otp
brandyscarney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.