-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[WIKI-887] fix: add scroll in heading layout #8596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: preview
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,8 @@ | |
| * See the LICENSE file for details. | ||
| */ | ||
|
|
||
| // plane imports | ||
| import { ScrollArea } from "@plane/propel/scrollarea"; | ||
| // plane web imports | ||
| import { PageNavigationPaneOutlineTabEmptyState } from "@/plane-web/components/pages/navigation-pane/tab-panels/empty-states/outline"; | ||
| // store | ||
|
|
@@ -23,12 +25,18 @@ export function PageNavigationPaneOutlineTabPanel(props: Props) { | |
| } = page; | ||
|
|
||
|
||
| return ( | ||
| <div className="size-full pt-3 space-y-1"> | ||
| <ScrollArea | ||
| orientation="vertical" | ||
| size="sm" | ||
| scrollType="hover" | ||
| className="size-full overflow-y-auto hide-scrollbar" | ||
| viewportClassName="px-4" | ||
| > | ||
| <PageContentBrowser | ||
| className="mt-0" | ||
| editorRef={editorRef} | ||
| emptyState={<PageNavigationPaneOutlineTabEmptyState />} | ||
| /> | ||
| </div> | ||
| </ScrollArea> | ||
|
Comment on lines
+28
to
+40
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: # First, find the ScrollArea component location
fd -e ts -e tsx "scroll" | grep -i area | head -20Repository: makeplane/plane Length of output: 190 🏁 Script executed: # Search for ScrollArea component definition in the codebase
rg -n "export.*ScrollArea" --type=ts --type=tsx -A 10Repository: makeplane/plane Length of output: 86 🏁 Script executed: # Check the actual file content to verify the code state
cat -n "apps/web/core/components/pages/navigation-pane/tab-panels/outline.tsx" | head -50Repository: makeplane/plane Length of output: 1460 🏁 Script executed: # Search for scrollType prop usage and its documentation
rg -n "scrollType" --type=ts --type=tsx -B 2 -A 2 | head -50Repository: makeplane/plane Length of output: 86 🏁 Script executed: # Check `@plane/propel` package structure
fd "scrollarea" -type dRepository: makeplane/plane Length of output: 229 🏁 Script executed: # Read ScrollArea implementation
cat -n "packages/propel/src/scrollarea/scrollarea.tsx"Repository: makeplane/plane Length of output: 4535 🏁 Script executed: # Check the alternative scroll-area implementation
cat -n "packages/ui/src/scroll-area.tsx"Repository: makeplane/plane Length of output: 3459 🏁 Script executed: # Search for hide-scrollbar class usage patterns
rg "hide-scrollbar" -nRepository: makeplane/plane Length of output: 190 🏁 Script executed: # Check if scrollType is defined/documented anywhere
rg "scrollType" -n -A 5 -B 5Repository: makeplane/plane Length of output: 16436 🏁 Script executed: # Verify hide-scrollbar class definition to confirm it hides scrollbars
rg "hide-scrollbar" -B 2 -A 2Repository: makeplane/plane Length of output: 545 🏁 Script executed: # Check if there are any docs or comments explaining the intent
cat -n "packages/propel/src/scrollarea/scrollarea.tsx" | grep -A 5 -B 5 "hover"Repository: makeplane/plane Length of output: 1675 Remove The 🤖 Prompt for AI Agents |
||
| ); | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The assets tab panel is missing a scrolling container. The original implementation had overflow-y-auto on the Tab.Panel wrapper (see removed line with "overflow-y-auto vertical-scrollbar scrollbar-sm"). After the refactor, while the outline tab got a ScrollArea component and the info tab has an overflow-y-auto wrapper, the assets tab only has static content without any scrolling mechanism.
For consistency with the other tabs and to prevent content from being cut off when the asset list is long, this should either:
The most consistent approach would be to use ScrollArea like the outline tab.