-
Notifications
You must be signed in to change notification settings - Fork 91
Open
Labels
Description
In performBump, the versions in packageInfos have already been bumped, including when the prebump hook is called:
beachball/src/bump/performBump.ts
Line 16 in f0f3f64
| await callHook(options.hooks?.prebump, modifiedPackages, packageInfos, options.concurrency); |
This contradicts the docs for prebump's version param (though this may be why the full packageInfos param was omitted):
beachball/src/types/BeachballOptions.ts
Lines 343 to 346 in f0f3f64
| * @param name The name of the package as defined in package.json | |
| * @param version The pre-bump version of the package to be published | |
| */ | |
| prebump?: (packagePath: string, name: string, version: string) => void | Promise<void>; |
This behavior is definitely wrong but could be a little risky to fix outside a major version, since people may be assuming the incorrect behavior.