Fix: preserve existing refresh_token when server omits it in refresh response#2280
Closed
Jah-yee wants to merge 1 commit intomodelcontextprotocol:mainfrom
Closed
Fix: preserve existing refresh_token when server omits it in refresh response#2280Jah-yee wants to merge 1 commit intomodelcontextprotocol:mainfrom
Jah-yee wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
…response Per RFC 6749 Section 6, the server MAY issue a new refresh token. If the response omits it, preserve the existing one to prevent can_refresh_token() from returning False after first refresh. Fixes modelcontextprotocol#2270
Contributor
|
fyi we have chosen to ban your account from mcp repos due to spamming PRs after I closed them with a warning |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2270
Per RFC 6749 Section 6, the server MAY issue a new refresh token. If the response omits it, preserve the existing one.
Many OAuth providers (Google, Auth0, Okta) omit refresh_token from refresh responses by default. The current behavior causes
can_refresh_token()to return False after the first refresh, forcing full re-authentication.