Skip to content

refactor(encryption): add typing and modernize IEncryptionModule #57551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshtrichards wants to merge 24 commits into
base: master
Choose a base branch
from
Open

refactor(encryption): add typing and modernize IEncryptionModule #57551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
e7b2d26
chore: add typing to IEncryptionModule
joshtrichards Jan 14, 2026
eef028e
chore: add type hints throughout IEncryptionModule implementation
joshtrichards Jan 14, 2026
6901bfb
chore: correct $position typing in IEncryptionModule
joshtrichards Jan 14, 2026
ca0be4e
chore: add exceptions to IEncryptionModule contract docs
joshtrichards Jan 14, 2026
f1fcd03
chore: add simple docblock to interface IEncryptionModule
joshtrichards Jan 14, 2026
1fd167e
chore: drop duplicated API docblocks from Encryption implementation
joshtrichards Jan 14, 2026
c9c9ea7
chore: add docblocks to non-interface helper/utility functions
joshtrichards Jan 14, 2026
1c6d28f
chore: document implementation specific throws
joshtrichards Jan 14, 2026
dff3fee
chore: drop implementation specific throws from interface
joshtrichards Jan 14, 2026
8adf7b7
chore: Update psalm-baseline.xml
joshtrichards Jan 14, 2026
8a3c617
chore: fixup to make $uid nullable for now
joshtrichards Jan 15, 2026
fa45758
chore: permit nullable $uid in IEncryptionModule.php...
joshtrichards Jan 15, 2026
0f6e5c5
refactor(encryption): Distinguish blockId from position
joshtrichards Jan 15, 2026
04dec46
chore: swap position for blockId in Encryption module implementation
joshtrichards Jan 15, 2026
c3768ac
refactor(encryption): differentiate blockId from $this->position
joshtrichards Jan 15, 2026
edf96ce
test(encryption): fix for typing + make testUser1/testUser2 realistic
joshtrichards Jan 15, 2026
1dab94d
chore: fixup typo
joshtrichards Jan 15, 2026
0727930
chore: add proper cast
joshtrichards Jan 15, 2026
34c91a2
chore: add formerly misssing getOwner from EncryptionTest
joshtrichards Jan 16, 2026
f1fd8bb
test: add missing stubs to EncryptionTest
joshtrichards Jan 16, 2026
d71c91a
test(encryption): add stub for needDetailedAccessList to UpdateTest
joshtrichards Jan 16, 2026
c260003
chore: add stub for getLegacyCipher to EncryptionTest
joshtrichards Jan 16, 2026
150c225
chore: fixup for lint
joshtrichards Jan 18, 2026
7ab2238
chore: lint
joshtrichards Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading