Restore (some) shareable links#981
Closed
JulianKniephoff wants to merge 10000 commits intoopencast:developfrom
Closed
Restore (some) shareable links#981JulianKniephoff wants to merge 10000 commits intoopencast:developfrom
JulianKniephoff wants to merge 10000 commits intoopencast:developfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #69, but see also my remarks in #69 (comment); I'm not sure if it closes it because people might want more state in their share links.
TL;DR this puts some of the Redux state in the URL so that you can share "deep links" into the application, as in: provide people with a link to the admin UI that directly opens the event details for a given event.
Right now you can link to:
The latter specifically necessitated putting some more state into Redux in the first place. Plus some adjacent refactoring. 🤷♀️
Creates links like http://localhost:3000/?persist%3AseriesDetails=%7B%22modal%22%3A%22%7B%5C%22show%5C%22%3Afalse%2C%5C%22page%5C%22%3A0%2C%5C%22series%5C%22%3A%7B%5C%22id%5C%22%3A%5C%22ID-av-portal%5C%22%2C%5C%22title%5C%22%3A%5C%22AV-Portal+Content%5C%22%7D%7D%22%2C%22_persist%22%3A%22%7B%5C%22version%5C%22%3A-1%2C%5C%22rehydrated%5C%22%3Atrue%7D%22%7D&persist%3AeventDetails=%7B%22modal%22%3A%22%7B%5C%22show%5C%22%3Atrue%2C%5C%22page%5C%22%3A0%2C%5C%22event%5C%22%3A%7B%5C%22end_date%5C%22%3A%5C%222024-11-14T01%3A13%3A19Z%5C%22%2C%5C%22agent_id%5C%22%3A%5C%22%5C%22%2C%5C%22displayable_status%5C%22%3A%5C%22EVENTS.EVENTS.STATUS.PROCESSED%5C%22%2C%5C%22needs_cutting%5C%22%3Afalse%2C%5C%22source%5C%22%3A%5C%22ARCHIVE%5C%22%2C%5C%22title%5C%22%3A%5C%22Weitsprung%5C%22%2C%5C%22has_open_comments%5C%22%3Afalse%2C%5C%22has_preview%5C%22%3Atrue%2C%5C%22technical_presenters%5C%22%3A%5B%5D%2C%5C%22has_comments%5C%22%3Afalse%2C%5C%22technical_end%5C%22%3A%5C%222024-11-14T01%3A13%3A19Z%5C%22%2C%5C%22series%5C%22%3A%7B%5C%22id%5C%22%3A%5C%22ID-av-portal%5C%22%2C%5C%22title%5C%22%3A%5C%22AV-Portal+Content%5C%22%7D%2C%5C%22presenters%5C%22%3A%5B%5C%22W%C3%A4lken%2C+Paul%5C%22%5D%2C%5C%22technical_start%5C%22%3A%5C%222024-11-14T01%3A03%3A03Z%5C%22%2C%5C%22location%5C%22%3A%5C%22%5C%22%2C%5C%22managedAcl%5C%22%3A%5C%22public%5C%22%2C%5C%22workflow_state%5C%22%3A%5C%22SUCCEEDED%5C%22%2C%5C%22id%5C%22%3A%5C%22ID-weitsprung%5C%22%2C%5C%22start_date%5C%22%3A%5C%222024-11-14T01%3A03%3A00Z%5C%22%2C%5C%22event_status%5C%22%3A%5C%22EVENTS.EVENTS.STATUS.PROCESSED%5C%22%2C%5C%22publications%5C%22%3A%5B%7B%5C%22name%5C%22%3A%5C%22EVENTS.EVENTS.DETAILS.PUBLICATIONS.ENGAGE%5C%22%2C%5C%22id%5C%22%3A%5C%22engage-player%5C%22%2C%5C%22url%5C%22%3A%5C%22https%3A%2F%2Fdevelop.opencast.org%2Fplay%2FID-weitsprung%5C%22%2C%5C%22enabled%5C%22%3Atrue%2C%5C%22hiding%5C%22%3Afalse%7D%5D%2C%5C%22date%5C%22%3A%5C%222024-11-14T01%3A03%3A00Z%5C%22%2C%5C%22selected%5C%22%3Afalse%7D%2C%5C%22workflowTabHierarchy%5C%22%3A%5C%22entry%5C%22%2C%5C%22assetsTabHierarchy%5C%22%3A%5C%22entry%5C%22%2C%5C%22workflowId%5C%22%3A%5C%22%5C%22%7D%22%2C%22_persist%22%3A%22%7B%5C%22version%5C%22%3A-1%2C%5C%22rehydrated%5C%22%3Atrue%7D%22%7D#, which is not pretty, but oh well, no one is expected to read and/or write these manually.