GH-132042: Fix calculation of slotdef index in update_one_slot() (#145880)

sergey-miryanov · web-flow · commit f10526553882 · 2026-03-12T23:16:53.000+01:00
diff --git a/Objects/typeobject.c b/Objects/typeobject.c
@@ -11737,7 +11737,7 @@ update_one_slot(PyTypeObject *type, pytype_slotdef *p, pytype_slotdef **next_p,
         if (Py_IS_TYPE(descr, &PyWrapperDescr_Type) &&
             ((PyWrapperDescrObject *)descr)->d_base->name_strobj == p->name_strobj) {
             void **tptr;
-            size_t index = (p - slotdefs) / sizeof(slotdefs[0]);
+            size_t index = (p - slotdefs);
             if (slotdefs_name_counts[index] == 1) {
                 tptr = slotptr(type, p->offset);
             }

Original file line number	Diff line number	Diff line change
`@@ -11737,7 +11737,7 @@ update_one_slot(PyTypeObject type, pytype_slotdef p, pytype_slotdef **next_p,`
`11737`	`11737`	`if (Py_IS_TYPE(descr, &PyWrapperDescr_Type) &&`
`11738`	`11738`	`((PyWrapperDescrObject *)descr)->d_base->name_strobj == p->name_strobj) {`
`11739`	`11739`	`void **tptr;`
`11740`		`- size_t index = (p - slotdefs) / sizeof(slotdefs[0]);`
	`11740`	`+ size_t index = (p - slotdefs);`
`11741`	`11741`	`if (slotdefs_name_counts[index] == 1) {`
`11742`	`11742`	`tptr = slotptr(type, p->offset);`
`11743`	`11743`	`}`