Command registration differs with @ActiveProfiles in tests vs jar spring.profiles.active= (4.0.1)

[fietser97]

We have an application with 2 profiles. (this worked in version 3)

1. The behavior between @activeprofiles and spring.profiles.active= is different. Where we would not expect this.
2. When using spring.profiles.active= we get application failed to start because it tries to autoconfigure a command it shouldn't

When we run tests we start the application with @activeprofiles("profileName") this works like expected.
When we run the application with java jar spring.profiles.active="profileName" - jar app.jar we get the following exception. (see at the end)
Even though in our profile it should not try to load this command and this "beanName".

How to reproduce:

• Create an spring shell application
• Create 2 spring profiles that load separate packages
• Try to run the jar with spring.profiles.active=

GOAL

• Make @ActiveProfile and spring.profiles.active= behave the same way
• Make spring.profiles.active= not load commands that are not within the active profiles components.

one profile config:

@Configuration
@Profile("profileName")
@ComponentScan(basePackages = "com.example.profileName")
public class profileNameConfiguration {
}

Test with profile:

@ActiveProfiles("profileName")
@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.NONE,
        classes = {Application.class},
        args = "helloWorld")
@ExtendWith(OutputCaptureExtension.class)
class ProfileTest {

    @Test
    void testCommandOutput(CapturedOutput output) {
        assertThat(output).contains("Hello world!");
    }
}

Log when running with profile:

Error starting ApplicationContext. To display the condition evaluation report re-run your application with 'debug' enabled.
ERROR 21 --- [main] o.s.b.d.LoggingFailureAnalysisReporter   : 

***************************
APPLICATION FAILED TO START
***************************

Description:

Method commandRegistry in org.springframework.shell.core.autoconfigure.CommandRegistryAutoConfiguration required a bean of type 'beanName' that could not be found.


Action:

Consider defining a bean of type 'BeanName in your configuration.

[czpilar]

Hello, I've just tried to reproduce this issue but I am unable to reproduce it. Here is the configuration I have tried:

Project structure

spring-shell-sample-spring-boot/
├── src/main/java/org/springframework/shell/samples/helloworld/
│   ├── boot/
│   │   ├── SpringShellApplication.java
│   │   └── ProfileNameConfiguration.java
│   └── profile/
│       └── ProfileCommands.java
└── src/test/java/org/springframework/shell/samples/helloworld/
    └── profile/
        └── ProfileCommandsTest.java

SpringShellApplication.java

package org.springframework.shell.samples.helloworld.boot;

import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;
import org.springframework.shell.core.command.annotation.Command;
import org.springframework.shell.core.command.annotation.Option;

@SpringBootApplication
public class SpringShellApplication {

	public static void main(String[] args) {
		SpringApplication.run(SpringShellApplication.class, args);
	}

	@Command(name = "hello", description = "Say hello to a given name", group = "Greetings",
			help = "A command that greets the user with 'Hello ${name}!'. Usage: hello [-n | --name]=<name>")
	public void sayHello(@Option(shortName = 'n', longName = "name", description = "the name of the person to greet",
			defaultValue = "World") String name) {
		System.out.println("Hello " + name + "!");
	}

}

ProfileNameConfiguration.java

package org.springframework.shell.samples.helloworld.boot;

import org.springframework.context.annotation.ComponentScan;
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.Profile;

@Configuration
@Profile("profileName")
@ComponentScan(basePackages = "org.springframework.shell.samples.helloworld.profile")
public class ProfileNameConfiguration {

}

ProfileCommands.java

package org.springframework.shell.samples.helloworld.profile;

import org.springframework.shell.core.command.annotation.Command;
import org.springframework.stereotype.Component;

@Component
public class ProfileCommands {

	@Command(name = "profileCommand",
			description = "A command that is only available when the 'profileName' profile is active")
	public void profileCommand() {
		System.out.println("This command is only available when the 'profileName' profile is active");
	}

}

Running without profile - profileCommand is NOT available (as expected)

./mvnw -pl org.springframework.shell:spring-shell-sample-spring-boot spring-boot:run

Running with profile - profileCommand IS available (as expected)

./mvnw -pl org.springframework.shell:spring-shell-sample-spring-boot spring-boot:run -Dspring-boot.run.profiles=profileName

Or equivalently:

./mvnw -pl org.springframework.shell:spring-shell-sample-spring-boot spring-boot:run -Dspring-boot.run.jvmArguments="-Dspring.profiles.active=profileName"

Test with @ActiveProfiles - works as expected

package org.springframework.shell.samples.helloworld.profile;

import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;

import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.boot.test.system.CapturedOutput;
import org.springframework.boot.test.system.OutputCaptureExtension;
import org.springframework.shell.samples.helloworld.boot.SpringShellApplication;
import org.springframework.test.context.ActiveProfiles;

import static org.assertj.core.api.Assertions.assertThat;

@ActiveProfiles("profileName")
@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.NONE, classes = { SpringShellApplication.class },
		properties = "spring.shell.interactive.enabled=false", args = "profileCommand")
@ExtendWith(OutputCaptureExtension.class)
class ProfileCommandsTest {

	@Test
	void testCommandOutput(CapturedOutput output) {
		assertThat(output).contains("This command is only available");
	}

}

I am not sure if this is your precise configuration but from your description it seems like it is. Could you share a minimal reproducer project or the exact configuration/classes that cause the issue? That would help me pinpoint the problem.