chore(repo): add agentcrumbs.dev support by ericallam · Pull Request #3206 · triggerdotdev/trigger.dev

ericallam · 2026-03-11T10:19:44Z

No description provided.

changeset-bot · 2026-03-11T10:19:51Z

⚠️ No Changeset found

Latest commit: cb6ad71

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-03-11T10:20:06Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

Walkthrough

Added extensive agentcrumbs documentation to CLAUDE.md (intent-skills, agentcrumbs overview, namespaces table, PR reviewer guidance, CLI usage) and reformatted a testcontainers example code block. Added runtime dependency agentcrumbs at version ^0.5.0 to package.json. Added agentcrumbs to minimumReleaseAgeExclude in pnpm-workspace.yaml and to serverDependenciesToBundle in apps/webapp/remix.config.js. No changes to exported/public declarations or runtime logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request has no description provided, missing all required template sections including testing, changelog, and checklist items.	Add a complete PR description following the template with testing steps, changelog, and checklist completion. At minimum, fill the Testing and Changelog sections.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'chore(repo): add agentcrumbs.dev support' clearly and concisely describes the main change: adding agentcrumbs support to the repository.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch repo/add-agentcrumbs

📝 Coding Plan

Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

🧹 Nitpick comments (1)

apps/webapp/remix.config.js (1)
15-15: Remove the incorrect premise about devDependencies; agentcrumbs is correctly declared as a regular dependency in package.json.

Line 15 bundles agentcrumbs, which is properly listed as a runtime dependency (v0.3.3) in the root package.json and will ship with the webapp. However, agentcrumbs is not imported or referenced anywhere in apps/webapp code. If the bundling is intentional for side effects or future use, consider adding a clarifying comment; otherwise, this entry may be unnecessary configuration noise.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@apps/webapp/remix.config.js` at line 15, The entry "agentcrumbs" in the
bundling list is misleading because it’s a regular runtime dependency but isn’t
imported or used anywhere in the webapp; either remove the "agentcrumbs" string
from the bundles array in remix.config.js to eliminate unnecessary configuration
noise, or if it’s intentionally bundled for side effects or future use, add a
clear inline comment next to the "agentcrumbs" entry explaining why it’s
included (so reviewers know it’s deliberate).

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@apps/webapp/remix.config.js`:
- Line 15: The entry "agentcrumbs" in the bundling list is misleading because
it’s a regular runtime dependency but isn’t imported or used anywhere in the
webapp; either remove the "agentcrumbs" string from the bundles array in
remix.config.js to eliminate unnecessary configuration noise, or if it’s
intentionally bundled for side effects or future use, add a clear inline comment
next to the "agentcrumbs" entry explaining why it’s included (so reviewers know
it’s deliberate).

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 1e9eb61a-1f47-4526-a6e2-089625f58715

📥 Commits

Reviewing files that changed from the base of the PR and between a793019 and 55a97d4.

📒 Files selected for processing (1)

apps/webapp/remix.config.js

📜 Review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Analyze (javascript-typescript)

🧰 Additional context used

📓 Path-based instructions (3)

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use function declarations instead of default exports

Files:

apps/webapp/remix.config.js

**/*.{js,ts,jsx,tsx,json,md,yaml,yml}

📄 CodeRabbit inference engine (AGENTS.md)

Format code using Prettier before committing

Files:

apps/webapp/remix.config.js

apps/**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (CLAUDE.md)

When modifying only server components (apps/webapp/, apps/supervisor/, etc.) with no package changes, add a .server-changes/ file instead of a changeset

Files:

apps/webapp/remix.config.js

🧠 Learnings (11)

📓 Common learnings

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: packages/cli-v3/CLAUDE.md:0-0
Timestamp: 2026-03-02T12:43:34.140Z
Learning: Keep SDK documentation in `rules/` and `.claude/skills/trigger-dev-tasks/` synchronized when features are added or changed

📚 Learning: 2025-11-27T16:26:58.661Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/webapp.mdc:0-0
Timestamp: 2025-11-27T16:26:58.661Z
Learning: Applies to apps/webapp/**/*.{ts,tsx} : Follow the Remix 2.1.0 and Express server conventions when updating the main trigger.dev webapp

Applied to files:

apps/webapp/remix.config.js

📚 Learning: 2026-03-02T12:43:34.140Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: packages/cli-v3/CLAUDE.md:0-0
Timestamp: 2026-03-02T12:43:34.140Z
Learning: Applies to packages/cli-v3/src/build/**/* : Bundle worker code using the build system in `src/build/` based on configuration from `trigger.config.ts`

Applied to files:

apps/webapp/remix.config.js

📚 Learning: 2025-11-27T16:26:37.432Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-27T16:26:37.432Z
Learning: Applies to packages/trigger-sdk/**/*.{ts,tsx} : In the Trigger.dev SDK (packages/trigger-sdk), prefer isomorphic code like fetch and ReadableStream instead of Node.js-specific code

Applied to files:

apps/webapp/remix.config.js

📚 Learning: 2025-11-27T16:27:35.304Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger.config.ts : Configure build process in trigger.config.ts using `build` object with external packages, extensions, and JSX settings

Applied to files:

apps/webapp/remix.config.js

📚 Learning: 2026-03-02T12:43:37.906Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: packages/core/CLAUDE.md:0-0
Timestamp: 2026-03-02T12:43:37.906Z
Learning: Applies to packages/core/**/*.{ts,tsx,js,jsx} : Never import the root package (trigger.dev/core). Always use subpath imports such as trigger.dev/core/v3, trigger.dev/core/v3/utils, trigger.dev/core/logger, or trigger.dev/core/schemas

Applied to files:

apps/webapp/remix.config.js

📚 Learning: 2026-03-02T12:43:48.124Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: packages/trigger-sdk/CLAUDE.md:0-0
Timestamp: 2026-03-02T12:43:48.124Z
Learning: Applies to packages/trigger-sdk/**/*.{ts,tsx,js,jsx} : Always import from `trigger.dev/sdk`. Never use `trigger.dev/sdk/v3` (deprecated path alias)

Applied to files:

apps/webapp/remix.config.js

📚 Learning: 2025-11-27T16:27:35.304Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use `trigger.dev/sdk/v3` for all imports in Trigger.dev tasks

Applied to files:

apps/webapp/remix.config.js

📚 Learning: 2025-11-27T16:27:35.304Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger.config.ts : Use build extensions in trigger.config.ts (additionalFiles, additionalPackages, aptGet, prismaExtension, etc.) to customize the build

Applied to files:

apps/webapp/remix.config.js

📚 Learning: 2025-11-27T16:26:58.661Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/webapp.mdc:0-0
Timestamp: 2025-11-27T16:26:58.661Z
Learning: Applies to apps/webapp/**/*.{ts,tsx} : When importing from `trigger.dev/core` in the webapp, use subpath exports from the package.json instead of importing from the root path

Applied to files:

apps/webapp/remix.config.js

📚 Learning: 2026-03-02T12:43:34.140Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: packages/cli-v3/CLAUDE.md:0-0
Timestamp: 2026-03-02T12:43:34.140Z
Learning: Applies to packages/cli-v3/src/build/**/* : Build system in `src/build/` should use configuration from `trigger.config.ts` in user projects to determine bundling, build extensions, and output structure

Applied to files:

apps/webapp/remix.config.js

devin-ai-integration

Devin Review found 5 potential issues.

CLAUDE.md

package.json

apps/webapp/remix.config.js

pnpm-workspace.yaml

CLAUDE.md

ericallam added 2 commits March 10, 2026 14:54

chore(repo): add agentcrumbs for better debug mode

6bbe999

update to 0.3.1

5a891b3

This comment was marked as resolved.

Sign in to view

coderabbitai bot reviewed Mar 11, 2026

View reviewed changes

ericallam added 2 commits March 11, 2026 11:05

update to agentcrumbs 03.3

8ed1270

bundle agentcrumbs in remix config

a34d6aa

ericallam force-pushed the repo/add-agentcrumbs branch from 55a97d4 to a34d6aa Compare March 11, 2026 11:06

ericallam added 2 commits March 12, 2026 10:14

Agentcrumbs 0.4.0

19acb4a

update to agentcrumbs 0.5.0

cb6ad71

This comment was marked as resolved.

Sign in to view

ericallam marked this pull request as ready for review March 13, 2026 13:31

devin-ai-integration bot reviewed Mar 13, 2026

View reviewed changes

CLAUDE.md Show resolved Hide resolved

package.json Show resolved Hide resolved

apps/webapp/remix.config.js Show resolved Hide resolved

pnpm-workspace.yaml Show resolved Hide resolved

CLAUDE.md Show resolved Hide resolved

nicktrn approved these changes Mar 13, 2026

View reviewed changes

ericallam merged commit 440c16c into main Mar 13, 2026
40 of 48 checks passed

ericallam deleted the repo/add-agentcrumbs branch March 13, 2026 13:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(repo): add agentcrumbs.dev support#3206

chore(repo): add agentcrumbs.dev support#3206
ericallam merged 6 commits intomainfrom
repo/add-agentcrumbs

ericallam commented Mar 11, 2026

Uh oh!

changeset-bot bot commented Mar 11, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Mar 11, 2026 •

edited

Loading

Reviews paused

❌ Failed checks (1 warning)

Uh oh!

This comment was marked as resolved.

Uh oh!

coderabbitai bot left a comment

Uh oh!

This comment was marked as resolved.

Uh oh!

devin-ai-integration bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

ericallam commented Mar 11, 2026

Uh oh!

changeset-bot bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Estimated code review effort

❌ Failed checks (1 warning)

Uh oh!

This comment was marked as resolved.

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot bot commented Mar 11, 2026 •

edited

Loading

coderabbitai bot commented Mar 11, 2026 •

edited

Loading