Skip to content

[Bug]: OSC 8 hyperlinks show confirmation dialog but do not open browser #3165

@laurencewalshe

Description

@laurencewalshe

Environment

  • App: Wave Terminal
  • OS: macOS 14.5 (arm64)
  • Default browser: Chrome
  • Shell: zsh 5.9

Summary

OSC 8 terminal hyperlinks render correctly and trigger Wave's "dangerous link" confirmation dialog, but clicking OK does not open the URL in the system browser. In the same environment, cmd-clicking a bare URL works as expected, and OSC 8 links work correctly in iTerm2.

Steps to Reproduce

  1. Open a local terminal in Wave.
  2. Run:
    printf '\e]8;;https://example.com\aClick me\e]8;;\a\n'
  3. Click the rendered Click me hyperlink.
  4. In the Wave confirmation dialog:

    Do you want to navigate to https://example.com?
    WARNING: This link could potentially be dangerous

  5. Click OK.

Actual Result

  • The confirmation dialog closes.
  • No browser window/tab opens.
  • No visible error is shown.

Expected Result

After clicking OK, Wave should open the URL (https://example.com) in the default system browser (same behavior as cmd-clicking a bare URL in Wave, or as OSC 8 in iTerm2).

Additional Notes

  • Cmd-clicking a plain URL like https://example.com in Wave successfully opens Chrome.
  • Running open https://example.com from the same terminal also opens Chrome.
  • Running the same OSC 8 printf command in iTerm2 opens the browser directly (no confirmation dialog, URL opens successfully).
  • This suggests the OSC 8 click handler in Wave correctly parses the hyperlink and shows the dialog, but doesn't complete the final step of invoking the system browser.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions