Conversation
|
@psorensen thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this? |
1239c7d to
55bca24
Compare
|
@dkotter How should I handle the VIP flag for |
So we've not been consistent with this so far in the codebase. We've basically done both, where we use Personally I'd prefer we go with the first approach, as this is technically a VIP approved plugin so it's nice to match their standards. We have had issues though a few times with timeouts, as some of these services take a bit to return. |
1bac627 to
b550389
Compare
|
sounds good @dkotter - I've included a helper function to facilitate a refactor of all the existing usage of |
|
@psorensen is this still WIP or can this formally go through review/merge? |
cf867a2 to
4139791
Compare
|
@dkotter @Sidsector9 back to you for review |
|
Let's hold this for the 4.0.0 release where we may have things timed that if the WP AI Client gets into WordPress 7.0 that we could publish this as a composer package, add test coverage, and ensure this covers all respective features and not just excerpt generation. |
|
@psorensen thanks for the PR! Could you please rebase your PR on top of the latest changes in the base branch? |
Description of the Change
This PR adds Azure Language Services as a provider and adds it to the Excerpt Generation feature.
Closes #159
How to test the Change
Testing Steps:
Changelog Entry
Credits
Props @psorensen @cadic @jeffpaul @Sidsector9 @dkotter
Checklist: