Skip to content

Fix OpenGL ES type issues in ACES2 FixedFunction Ops#2281

Open
remia wants to merge 3 commits intoAcademySoftwareFoundation:mainfrom
remia:fix-aces2-opengles
Open

Fix OpenGL ES type issues in ACES2 FixedFunction Ops#2281
remia wants to merge 3 commits intoAcademySoftwareFoundation:mainfrom
remia:fix-aces2-opengles

Conversation

@remia
Copy link
Copy Markdown
Collaborator

@remia remia commented Apr 7, 2026

Address #2269

Signed-off-by: Rémi Achard <remiachard@gmail.com>
Comment thread src/OpenColorIO/ops/fixedfunction/FixedFunctionOpGPU.cpp Outdated
@doug-walker doug-walker requested a review from KevinJW April 7, 2026 21:46
Co-authored-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Rémi Achard <remiachard@gmail.com>
@remia remia force-pushed the fix-aces2-opengles branch from 0f4dc80 to 19892f9 Compare April 13, 2026 12:16
Signed-off-by: Rémi Achard <remiachard@gmail.com>
@KevinJW
Copy link
Copy Markdown
Contributor

KevinJW commented Apr 13, 2026

Have not looked at the exact code this now emits, but when I looked at the original issue, I did wonder about the code in the cusp table ...

  int i_lo = int(max(float(0), float(i + 0)));
  int i_hi = int(min(float(361), float(i + 2)));

The original blink/c++/etc assumed integer division properties when doing the binary search so used integer types. I guess we'll need to check carefully about all these type conversions and the available function support under the various shader languages.

@remia
Copy link
Copy Markdown
Collaborator Author

remia commented Apr 14, 2026

Just double checked with the OpenGL ES tests I'm running, all tests pass successfully provided I'm using the following defaults precision qualifier (without this almost everything fails).

precision highp float;
precision highp int;
precision highp sampler2D;
precision highp sampler3D;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Type Mismatch in GLES 3.0 Shader Code of _Add_Reach_table() and _Add_Cusp_table()

3 participants