Allow for geographies to exist between meta and seed geographies#217
Open
JoeJimFlood wants to merge 1 commit intoActivitySim:masterfrom
Open
Allow for geographies to exist between meta and seed geographies#217JoeJimFlood wants to merge 1 commit intoActivitySim:masterfrom
JoeJimFlood wants to merge 1 commit intoActivitySim:masterfrom
Conversation
|
Hi @JoeJimFlood this is great, I can take a closer look but a couple of things off the top of my head:
If you can tackle the first one before I can get to this PR, it would definitely expedite things! |
Author
|
@nick-fournier Thanks for reviewing it! I actually had already agreed to write a unit test, though figuring out exactly how has been a challenge. Right now I'm leaning towards running the CALM example with and without a geography in between the District and PUMA levels and checking that the outputs are the same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it currently stands, there is an implicit assumption in the code that the seed geography will be one level below the meta geography in the hierarchy. The CDOT implementation needs a geography in between the two. This pull request allows for any number of geographies in between the meta and seed geographies.