Skip to content

Allow for geographies to exist between meta and seed geographies#217

Open
JoeJimFlood wants to merge 1 commit intoActivitySim:masterfrom
camsys:allow_intermediate_geographies
Open

Allow for geographies to exist between meta and seed geographies#217
JoeJimFlood wants to merge 1 commit intoActivitySim:masterfrom
camsys:allow_intermediate_geographies

Conversation

@JoeJimFlood
Copy link

@JoeJimFlood JoeJimFlood commented Feb 3, 2026

As it currently stands, there is an implicit assumption in the code that the seed geography will be one level below the meta geography in the hierarchy. The CDOT implementation needs a geography in between the two. This pull request allows for any number of geographies in between the meta and seed geographies.


@nick-fournier
Copy link

Hi @JoeJimFlood this is great, I can take a closer look but a couple of things off the top of my head:

  • I want to write some unit tests to confirm it works, and locks in those gains.
  • I want to also make sure it doesn't mess with downstream summary outputs. I remember there was an issue where it doesn't like when you request the zone totals for a zone above the smallest zone. Need to track down that issue.

If you can tackle the first one before I can get to this PR, it would definitely expedite things!

@JoeJimFlood
Copy link
Author

@nick-fournier Thanks for reviewing it! I actually had already agreed to write a unit test, though figuring out exactly how has been a challenge. Right now I'm leaning towards running the CALM example with and without a geography in between the District and PUMA levels and checking that the outputs are the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants