[WIP] Feature: Support TRUNCATE TABLE for Iceberg engine #1529
Check failed
There are 7 commits incorrectly signed off, the check did not pass.
Summary
| Sha | Message | Pass or fail reason | |
|---|---|---|---|
| 🔴 | de68832 | [WIP] (DONOTMERGE) Feature: Support TRUNCATE TABLE... | Sign-off not found |
| 🔴 | 601250f | Fix: Address code review feedback and drop statele... | Sign-off not found |
| 🔴 | 27a8467 | Fix: Properly escape Iceberg namespace in DataLake... | Sign-off not found |
| 🔴 | 84d76f1 | Fix: Add missing S3 credentials to ClickHouse Data... | Sign-off not found |
| 🔴 | c81fc7f | Fix: Remove invalid DataLakeCatalog S3 settings | Sign-off not found |
| 🔴 | 876577b | Fix: Restore minio_secret_key variable for DataLak... | Sign-off not found |
| 🟢 | cc1c7db | Merge branch 'antalya-26.1' into feature/iceberg-t... | Skipped: sign-off not required in merge commit |
| 🔴 | 5a7e014 | Fix: Dynamically determine Iceberg format version ... | Sign-off not found |
Errors details
Sign-off not found
No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.
To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).
How to fix missing or invalid sign-offs
Option 1: add remediation commit
Option 2: fix commits without sign-off
Rebase the branch
If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").
Warning
You should only do this if:
- You are the only author of the commits in this branch
- You are absolutely certain nobody else is doing any work based upon this branch
- There are no empty commits in the branch
To add your Signed-off-by line to every commit in this branch:
- Ensure you have a local copy of your branch by checking out the pull request locally via command line.
- In your local branch, run:
git rebase HEAD~8 --signoff - Force push your changes to overwrite the branch:
git push --force-with-lease origin feature/iceberg-truncate