feat: Add shell mode for autocompletion of commands.#118
feat: Add shell mode for autocompletion of commands.#118
Conversation
subkanthi
changed the title
| logger.error("Fatal", ex); | ||
| return 1; | ||
| }); | ||
| if (args.length == 0) { |
There was a problem hiding this comment.
default into shell mode
There was a problem hiding this comment.
I often use ice with no args to show the help menu with commands. I can still use ice --help to avoid shell mode but how do I show the same help info when inside shell mode? The help command doesn't include flags like this:
Iceberg REST Catalog client.
-c, --config=<configFile>
/path/to/config.yaml ($CWD/.ice.yaml by default)
There was a problem hiding this comment.
thats exactly why I added this comment, because wasnt sure if this is right thing to default to shell mode, maybe I can remove the default for now
There was a problem hiding this comment.
@xieandrew removed default to shell mode.
| String line = reader.readLine(prompt); | ||
| systemRegistry.execute(line); | ||
| } catch (UserInterruptException e) { | ||
| // Ctrl+C - ignore |
There was a problem hiding this comment.
I am unable to use Ctrl+C to exit shell mode when there's no command currently running, is that intentional? The fix would be to add System.exit(0) here.
2 participants
closes: #110