-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: add context compression hooks for plugin extensibility -还未自测,但是修改内容不多,如果可以的话可以直接合并 #5291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
evpeople
wants to merge
3
commits into
AstrBotDevs:master
Choose a base branch
from
evpeople:feat/add-context-compression-hook
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: 考虑在记录钩子失败时带上完整的 traceback,以便更容易调试。
使用
logger.warning(..., exc_info=e)(或直接使用logger.exception(...))可以保留 traceback,而不只是错误信息,这会让钩子失败问题更容易定位,同时仍然将其视作非致命错误。请在前置钩子和后置钩子中都采用这一做法。建议实现:
try/except中也采用同样的模式,例如:except Exception as e: return ...替换为:except Exception as e: logger.warning("Context before-hook failed", exc_info=e); return ...并使用合适的日志消息字符串。
logger,请在文件顶部添加:import logginglogger = logging.getLogger(__name__)Original comment in English
suggestion: Consider logging hook failures with full traceback for easier debugging.
Using
logger.warning(..., exc_info=e)(or justlogger.exception(...)) will preserve the traceback instead of only the message, which makes hook failures much easier to diagnose while still treating them as non-fatal. Apply this to both the before and after hooks.Suggested implementation:
try/exceptin this file, e.g.:except Exception as e: return ...with:except Exception as e: logger.warning("Context before-hook failed", exc_info=e); return ...using an appropriate message string.
logger, add at the top of the file:import logginglogger = logging.getLogger(__name__)