{Core} Adjust "command not found" scenarios to fail fast. #32826
Closed
DanielMicrosoft wants to merge 5 commits intoAzure:devfrom
Closed
{Core} Adjust "command not found" scenarios to fail fast. #32826DanielMicrosoft wants to merge 5 commits intoAzure:devfrom
DanielMicrosoft wants to merge 5 commits intoAzure:devfrom
Conversation
❌AzureCLI-FullTest
|
|
Hi @DanielMicrosoft, |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| rebuild-index | cmd rebuild-index added |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
jiasli and
yonzhan
microsoft-github-policy-service
bot
added
Auto-Assign
DanielMicrosoft
force-pushed
the
36654220-command-not-found-fail-fast
branch
from
f4ac334 to
b1b7fa4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
This PR prevents
azure-clifrom doing a full module load in the event that a command is not found.The implementation of this feature will require altering of when the
commandIndexis re-built.It will also require a change to workflows in air-gapped environments. Where developers may manually install
whlfiles, as we will rely on rebuilding commandIndex at the "end" of an operation that should normally require a rebuild on the next command used (the extension "CRUD" operations). This PR implements a manual way (via a newly created command) to refresh thecommandIndex.Checklist:
commandIndexbe covered (should just always go to fallback of loading all modules).commandIndexin their config?).az VERSION)."Context.Default.AzureCLI.RawCommand": "rebuild-index").extensionoperations.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.