Skip to content

Fix stats beat failure count metrics reporting incorrect values #47884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeanbisutti merged 2 commits into from
Feb 4, 2026
Merged

Fix stats beat failure count metrics reporting incorrect values #47884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de66c95
Fix statsbeat failure count metrics reporting incorrect values
jeanbisutti Feb 3, 2026
50b5208
Merge branch 'main' into jean/fix-statsbeat-failure-count-metrics
jeanbisutti Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...e/monitor/opentelemetry/autoconfigure/implementation/statsbeat/NonessentialStatsbeat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,14 @@ protected void send(TelemetryItemExporter telemetryItemExporter) {
long readFailures = readFailureCount.getAndSet(0);
if (readFailures != 0) {
StatsbeatTelemetryBuilder telemetryItem
= createStatsbeatTelemetry(READ_FAILURE_COUNT, (double) readFailureCount.get());
= createStatsbeatTelemetry(READ_FAILURE_COUNT, (double) readFailures);
telemetryItemExporter.send(Collections.singletonList(telemetryItem.build()));
}

long writeFailures = readFailureCount.getAndSet(0);
long writeFailures = writeFailureCount.getAndSet(0);
if (writeFailures != 0) {
StatsbeatTelemetryBuilder telemetryItem
= createStatsbeatTelemetry(WRITE_FAILURE_COUNT, (double) writeFailureCount.get());
= createStatsbeatTelemetry(WRITE_FAILURE_COUNT, (double) writeFailures);
telemetryItemExporter.send(Collections.singletonList(telemetryItem.build()));
}
}
Expand Down
105 changes: 105 additions & 0 deletions ...nitor/opentelemetry/autoconfigure/implementation/statsbeat/NonessentialStatsbeatTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,20 @@

package com.azure.monitor.opentelemetry.autoconfigure.implementation.statsbeat;

import com.azure.monitor.opentelemetry.autoconfigure.implementation.models.MetricDataPoint;
import com.azure.monitor.opentelemetry.autoconfigure.implementation.models.MetricsData;
import com.azure.monitor.opentelemetry.autoconfigure.implementation.models.TelemetryItem;
import com.azure.monitor.opentelemetry.autoconfigure.implementation.pipeline.TelemetryItemExporter;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.mockito.ArgumentCaptor;

import java.util.List;

import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.Mockito.atLeastOnce;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;

public class NonessentialStatsbeatTest {

Expand Down Expand Up @@ -34,4 +44,99 @@ public void testIncrementWriteFailureCount() {
}
assertThat(nonessentialStatsbeat.getWriteFailureCount()).isEqualTo(100);
}

@Test
@SuppressWarnings("unchecked")
public void testSendReadFailureCount() {
TelemetryItemExporter mockExporter = mock(TelemetryItemExporter.class);

for (int i = 0; i < 5; i++) {
nonessentialStatsbeat.incrementReadFailureCount();
}

nonessentialStatsbeat.send(mockExporter);

// Capture all sent telemetry items
ArgumentCaptor<List<TelemetryItem>> telemetryItemCaptor = ArgumentCaptor.forClass(List.class);
verify(mockExporter, atLeastOnce()).send(telemetryItemCaptor.capture());

// Find and verify the Read_Failure_Count metric
MetricDataPoint readFailureMetric = findMetricByName(telemetryItemCaptor.getAllValues(), "Read_Failure_Count");
assertThat(readFailureMetric).isNotNull();
assertThat(readFailureMetric.getValue()).isEqualTo(5.0);

// Counter should be reset after send
assertThat(nonessentialStatsbeat.getReadFailureCount()).isEqualTo(0);
}

@Test
@SuppressWarnings("unchecked")
public void testSendWriteFailureCount() {
TelemetryItemExporter mockExporter = mock(TelemetryItemExporter.class);

for (int i = 0; i < 3; i++) {
nonessentialStatsbeat.incrementWriteFailureCount();
}

nonessentialStatsbeat.send(mockExporter);

// Capture all sent telemetry items
ArgumentCaptor<List<TelemetryItem>> telemetryItemCaptor = ArgumentCaptor.forClass(List.class);
verify(mockExporter, atLeastOnce()).send(telemetryItemCaptor.capture());

// Find and verify the Write_Failure_Count metric
MetricDataPoint writeFailureMetric
= findMetricByName(telemetryItemCaptor.getAllValues(), "Write_Failure_Count");
assertThat(writeFailureMetric).isNotNull();
assertThat(writeFailureMetric.getValue()).isEqualTo(3.0);

// Counter should be reset after send
assertThat(nonessentialStatsbeat.getWriteFailureCount()).isEqualTo(0);
}

@Test
@SuppressWarnings("unchecked")
public void testSendReadAndWriteFailure() {
TelemetryItemExporter mockExporter = mock(TelemetryItemExporter.class);

for (int i = 0; i < 2; i++) {
nonessentialStatsbeat.incrementReadFailureCount();
}
for (int i = 0; i < 5; i++) {
nonessentialStatsbeat.incrementWriteFailureCount();
}

nonessentialStatsbeat.send(mockExporter);

// Capture all sent telemetry items
ArgumentCaptor<List<TelemetryItem>> telemetryItemCaptor = ArgumentCaptor.forClass(List.class);
verify(mockExporter, atLeastOnce()).send(telemetryItemCaptor.capture());

List<List<TelemetryItem>> allCapturedValues = telemetryItemCaptor.getAllValues();

// Find and verify Read_Failure_Count metric
MetricDataPoint readFailureMetric = findMetricByName(allCapturedValues, "Read_Failure_Count");
assertThat(readFailureMetric).isNotNull();
assertThat(readFailureMetric.getValue()).isEqualTo(2.0);

// Find and verify Write_Failure_Count metric
MetricDataPoint writeFailureMetric = findMetricByName(allCapturedValues, "Write_Failure_Count");
assertThat(writeFailureMetric).isNotNull();
assertThat(writeFailureMetric.getValue()).isEqualTo(5.0);

// Both counters should be reset after send
assertThat(nonessentialStatsbeat.getReadFailureCount()).isEqualTo(0);
assertThat(nonessentialStatsbeat.getWriteFailureCount()).isEqualTo(0);
}

private MetricDataPoint findMetricByName(List<List<TelemetryItem>> allCapturedValues, String metricName) {
return allCapturedValues.stream()
.flatMap(List::stream)
.filter(item -> item.getData().getBaseData() instanceof MetricsData)
.map(item -> (MetricsData) item.getData().getBaseData())
.flatMap(metricsData -> metricsData.getMetrics().stream())
.filter(metric -> metricName.equals(metric.getName()))
.findFirst()
.orElse(null);
}
}