Fix stats beat failure count metrics reporting incorrect values#47884
Merged
jeanbisutti merged 2 commits intomainfrom Feb 4, 2026
Merged
Fix stats beat failure count metrics reporting incorrect values#47884jeanbisutti merged 2 commits intomainfrom
jeanbisutti merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes critical bugs in the statsbeat failure count metrics reporting where incorrect values were being sent to telemetry. The bugs were caused by using the wrong variables when creating telemetry items - the code was reading from atomic counters after they had been reset instead of using the captured values, and there was a copy-paste error where readFailureCount was used instead of writeFailureCount.
Changes:
- Fixed three bugs in
NonessentialStatsbeat.send()method that caused incorrect metric values to be reported - Added comprehensive test coverage to verify the fixes and prevent regression
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| NonessentialStatsbeat.java | Fixed bugs on lines 38, 42, and 45: using captured values instead of re-reading atomic counters, and correcting copy-paste error where readFailureCount was used instead of writeFailureCount |
| NonessentialStatsbeatTest.java | Added three new test methods to verify correct metric values are sent and counters are properly reset after sending |
alzimmermsft
approved these changes
Feb 3, 2026
trask
approved these changes
Feb 3, 2026
rajkumar-rangaraj
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bugs related to stats beat read and write failure count.