-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[VoiceLive] Update live tests #44836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xitzhang
wants to merge
2
commits into
main
Choose a base branch
from
xitzhang/vl_livetests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+615
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates Azure AI VoiceLive live tests to use a new set of test assets and resource provisioning outputs, aligning the test data layout and several test expectations.
Changes:
- Switched live-test environment variables to
AI_SERVICES_ENDPOINT/AI_SERVICES_KEY. - Moved live test audio inputs to a local
tests/assetdirectory and updated tests to reference new audio filenames. - Added new media assets and an ARM template (
test-resources.json) for provisioning AI Services resources and outputting endpoint/key.
Reviewed changes
Copilot reviewed 5 out of 14 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/ai/azure-ai-voicelive/tests/voicelive_preparer.py | Updates env var names used to load endpoint/key for live tests. |
| sdk/ai/azure-ai-voicelive/tests/test_live_realtime_service.py | Updates referenced audio files and adjusts some expected counters; adds a skipped test. |
| sdk/ai/azure-ai-voicelive/tests/conftest.py | Changes the test asset directory fixture to a local tests/asset folder. |
| sdk/ai/azure-ai-voicelive/tests/asset/largest_lake.ulaw | Adds a new audio asset for live tests. |
| sdk/ai/azure-ai-voicelive/tests/asset/largest_lake.alaw | Adds a new audio asset for live tests. |
| sdk/ai/azure-ai-voicelive/tests/asset/largest_lake.8kHz.wav | Adds a new audio asset for live tests. |
| sdk/ai/azure-ai-voicelive/tests/asset/largest_lake.16kHz.wav | Adds a new audio asset for live tests. |
| sdk/ai/azure-ai-voicelive/tests/asset/ask_weather.mp3 | Adds a new audio asset for live tests. |
| sdk/ai/azure-ai-voicelive/sdk/ai/azure-ai-voicelive/tests/asset/4-1.wav | Adds a new audio input used by multiple live tests. |
| sdk/ai/azure-ai-voicelive/tests/asset/ask_weather.wav | Adds a new audio input used by live tests. |
| sdk/ai/azure-ai-voicelive/tests/asset/filler_word_24kHz.wav | Adds a new audio input used by live tests. |
| sdk/ai/azure-ai-voicelive/tests/asset/largest_lake.44kHz.wav | Adds a new audio asset for live tests. |
| sdk/ai/azure-ai-voicelive/tests/asset/largest_lake.wav | Adds a new audio asset for live tests. |
| sdk/ai/azure-ai-voicelive/test-resources.json | Adds/updates resource provisioning template and outputs AI_SERVICES_* values. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines