Rewrite the lexer and parser in human_encoding#354
Open
ivanlele wants to merge 1 commit intoBlockstreamResearch:masterfrom
Open
Rewrite the lexer and parser in human_encoding#354ivanlele wants to merge 1 commit intoBlockstreamResearch:masterfrom
ivanlele wants to merge 1 commit intoBlockstreamResearch:masterfrom
Conversation
Contributor
Author
|
We used CI to scan one of our projects for license compliance, and found that a dependency of rust-simplicity has an incompatible license with the CC0 license used by rust-simplicity: |
Contributor
Author
|
@apoelstra, In src/human_parsing/README.md, I saw that we already planned to move away from this toolkit, so it shouldn't be a major issue? License compliance might currently block few of our releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the toolkit used in the human_encoding module with a logos lexer and a custom parser.