fix: enable JavaScript for code block syntax highlighting in PDF export (fixes #2984)#3772
Open
KJyang-0114 wants to merge 1 commit intoBoostIO:masterfrom
Open
fix: enable JavaScript for code block syntax highlighting in PDF export (fixes #2984)#3772KJyang-0114 wants to merge 1 commit intoBoostIO:masterfrom
KJyang-0114 wants to merge 1 commit intoBoostIO:masterfrom
Conversation
The PDF export was failing to display code blocks with syntax highlighting because JavaScript was disabled in the print window. This fixes issue BoostIO#2984.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the PDF export issue where code blocks were not displaying with syntax highlighting.
Problem
The PDF export feature was not rendering code blocks with syntax highlighting because JavaScript was disabled in the print window (line 8 in formatPDF.js: javascript: false). Since the code block highlighting relies on CodeMirror which runs in the browser, disabling JavaScript prevented it from executing.
Solution
Enable JavaScript in the PDF export window by changing:
javascript: false to javascript: true
This allows CodeMirror syntax highlighting to run during PDF generation.
Testing
Related Issue