[FIX] Use dynamic current_fps in CEA-708 SCC frame delay calculations#2173
Open
Atul-Chahar wants to merge 1 commit intoCCExtractor:masterfrom
Open
[FIX] Use dynamic current_fps in CEA-708 SCC frame delay calculations#2173Atul-Chahar wants to merge 1 commit intoCCExtractor:masterfrom
Atul-Chahar wants to merge 1 commit intoCCExtractor:masterfrom
Conversation
…C frame delays Replace all 6 hardcoded 1000/29.97 frame delay calculations in dtvcc_write_scc() with 1000/current_fps so that CEA-708 SCC output uses the actual stream framerate instead of assuming NTSC 29.97. Fixes CCExtractor#2172
Contributor
Author
|
Tested locally on Linux: Build: Version: Rust tests: |
Collaborator
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit f377be9...:
Congratulations: Merging this PR would fix the following tests:
All tests passed completely. Check the result page for more info. |
Collaborator
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit f377be9...:
Your PR breaks these cases:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Summary
dtvcc_write_scc()inccx_decoders_708_output.cuses hardcoded1000 / 29.97in 6 places to calculate frame delay offsets for CEA-708 SCC output. This causes incorrect subtitle timing on non-NTSC streams (25fps PAL, 23.976 film, 24fps, etc.).This is the same class of bug fixed for CEA-608 in #2146, but in the CEA-708 (DTVCC) output path.
Fix
Replaced all 6 instances of
1000 / 29.97with1000 / current_fps. Thecurrent_fpsglobal is already accessible via the existing include chain — no new headers needed.Changes
src/lib_ccx/ccx_decoders_708_output.c— 6 lines changed indtvcc_write_scc()docs/CHANGES.TXT— added changelog entryFixes #2172