Change directory structure to match website#247
Conversation
troyraen
added
maintenance
tox.ini
Outdated
| # Make a list of the tutorials changed, we only need this in CI. Also deal with grep's non-zero exit code. | ||
| bash -c 'if [[ $CI == true ]]; then git fetch origin main --depth=1; git diff origin/main --name-only tutorials | grep ".md" || true; fi > changed_tutorials' | ||
| # Make a list of the tutorials changed, excluding deleted files. We only need this in CI. Also deal with grep's non-zero exit code. | ||
| bash -c 'if [[ $CI == true ]]; then git fetch origin main --depth=1; git diff origin/main --name-only --diff-filter=d tutorials | grep ".md" || true; fi > changed_tutorials' |
There was a problem hiding this comment.
@bsipocz here's the line I had to change in order for the build to pass. Before this, it was failing because it was trying to find a file that had been deleted. (The file isn't actually deleted, just moved, but enough of the file contents were changed that git treats it as deleting the original file and adding a new one.)
Is there a different way you think we should handle that?
There was a problem hiding this comment.
as I see the problem is not just about the deletion, but also about treating the landing pages as tutorials.
I would push this and another fix, too into #248. That would also ensure that we don't mix big content refactoring PRs with config and infrastructure changes.
There was a problem hiding this comment.
It makes sense to put it in a different PR. I'll remove that commit from here and rebase onto your #248 branch.
There was a problem hiding this comment.
Added a commit. At the end I left the ignore for the deletes, but I don't think it's actually necessary.
There was a problem hiding this comment.
Other PR is in, so if you interactive rebased this one and leave out the commit all should be fine and conflict less.
troyraen
force-pushed
the
raen/issues/225/change-dir-structure
branch
from
423d9d2 to
492fea5
Compare
|
Ok, I think this is ready to go. The oldest deps job ran into #251. Seems unrelated to this PR. |
bsipocz
left a comment
bsipocz
left a comment
There was a problem hiding this comment.
Merging this now as links pointing to these pages from astroquery are already broken and I rather not change them twice.
…structure Change directory structure to match website 2d0648b
2 participants
Closes #225