[ENG-10256] 2.1.9 BE: Fix permission issue where users without permission to an object can access the metadata#11588
Merged
futa-ikeda merged 5 commits intoCenterForOpenScience:feature/fair-signpostingfrom Feb 16, 2026
Conversation
…access the metadata (add decorator is_contributor_or_public_resource)
Ostap-Zherebetskyi
requested changes
Feb 16, 2026
Collaborator
Ostap-Zherebetskyi
left a comment
Ostap-Zherebetskyi
left a comment
There was a problem hiding this comment.
Please update the decorator to improve its readability and reusability, and add unit tests.
futa-ikeda
merged commit 9fc1c84
into
CenterForOpenScience:feature/fair-signposting
8 checks passed
adlius
pushed a commit
that referenced
this pull request
Feb 24, 2026
* linkset initial implementation * linkset initial implementation (updating data extraction and adding serialization) * and \n in EOF instead of % * update code * get file mediatype from metadata * add unittests for linkset approach (TODO: ?) * update code * update code and unit tests and * update file related code and unit tests * refactor code after CR | implement 'describes' | check file type differs from parent project / registry / preprint * update files to compare on unittests run * implement datacite - scheme type mapping for linkset draft version (need tests updates and maybe some type yield logic ) * Update osf/metadata/osf_gathering.py Co-authored-by: abram axel booth <aaxelb@users.noreply.github.com> * Update osf/metadata/serializers/linkset.py Co-authored-by: abram axel booth <aaxelb@users.noreply.github.com> * implement datacite - schema mapping * update tests expected results * resolve CR * refactor code | resolve CR * remove redundant describes from file response (#11590) * [ENG-10256] 2.1.9 BE: Fix permission issue where users without permission to an object can access the metadata (#11588) * Fix permission issue where users without permission to an object can access the metadata (add decorator is_contributor_or_public_resource) * refactor code * resolve CR | refactor code * resolve CR | add unittests * add *args, **kwargs for decorated view * [ENG-10167] 2.1.6 BE: add link header to guid metadata endpoints (#11594) * add link header to guid metadata endpoints for registry and project * update code * avoid Component Registration/Project JSON Contains type: null (#11597) * [ENG-10168] 2.1.7 BE: add link header to cedar metadata records endpoints (#11596) * add link header to guid metadata endpoints for registry and project * update code * add link header to cedar metadata records endpoints * change ResearchProject for CreativeWork for projects (#11603) * [ENG-10169] 2.1.8 BE: add link header to file download URL (#11600) * avoid Component Registration/Project JSON Contains type: null * add link header to file download URL * update unittests * resolve CR --------- Co-authored-by: mkovalua <mkoval@exoft.net> Co-authored-by: abram axel booth <aaxelb@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Purpose
Currently a private project’s metadata can be accessed via the URL osf.io/metadata/<project_guid>/?format=xyz
Expected behavior:
This URL should return a 403 status code and an appropriate error message and not allow users without proper permissions to download the metadata
Changes
implement
is_contributor_or_public_resource(to be it reusable for other calls if needed in future) where is checking if resource is public or auth user is a contributor96b6-b807-4ade-89d1-3e4ba47b8e95.mp4
Side Effects
QE Notes
CE Notes
Documentation