Add CAIP-350 profiles for bip122, starknet#172
Add CAIP-350 profiles for bip122, starknet#1720xrcinus wants to merge 11 commits intoChainAgnostic:mainfrom
Conversation
…espaces into 350-bip122-starknet
bip122/caip350.md
Outdated
|
|
||
| ### Extra considerations | ||
|
|
||
| Wallets and other software are expected to be able to fetch the extra information needed to convert from [CAIP-2](caip2.md) to produce the corresponding identifier defined by this standard. |
There was a problem hiding this comment.
I would maybe remove this since in this profile there IS no extra information needed?
bip122/caip350.md
Outdated
|
|
||
| ### Extra considerations | ||
|
|
||
| Wallets and other software are expected to be able to fetch the extra information needed to convert from [CAIP-2](caip2.md) to produce the corresponding identifier defined by this standard. |
There was a problem hiding this comment.
I would maybe remove this since in this profile there IS no extra information needed?
starknet/caip350.md
Outdated
|
|
||
| ### Extra considerations | ||
|
|
||
| Wallets and other software are expected to be able to fetch the extra information needed to convert from [CAIP-2](caip2.md) to produce the corresponding identifier defined by this standard. |
bumblefudge
left a comment
bumblefudge
left a comment
There was a problem hiding this comment.
Other than removing what I think are vestigial implementation considerations re: CAIP-2 non-roundtrippability, I think these are good to go?
I'd also welcome a PR fixing the solana headers, I just noticed them when working on this PR.
|
thanks so much, updated! |
| ### Text representation | ||
|
|
||
| ``` | ||
| <genesis_hash_prefix> |
There was a problem hiding this comment.
Nit: Is this necessary to then simply say 'Where <genesis_hash_prefix is' .. ?
|
|
||
| ## Namespace Reference | ||
|
|
||
| ChainType binary key: `0x0001` |
There was a problem hiding this comment.
Nit: When I 'View File' these are not being rendered on separate lines. Same in both files.
5 participants
This PR adds a CAIP-350 profile for bip122 and starknet, based on the latest template