Closed
Conversation
LesnyRumcajs
requested review from
akaladarshi and
sudo-shashank
and removed request for
a team
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
WalkthroughAdds a new GitHub Actions workflow Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer Push
participant Actions as GitHub Actions
participant App as GitHub App
participant Checkout as actions/checkout
participant Mise as mise-action
participant Git as Git (commit/push)
Dev->>Actions: push event (any branch)
Actions->>App: create App token (LESHY_APP_ID / LESHY_APP_PRIVATE_KEY)
Actions->>Checkout: checkout repo (full history)
Actions->>Mise: install tooling & run "mise format"
Mise->>Actions: report changes (git diff)
alt changes found
Actions->>Git: commit "[LeshyBot] Apply automatic formatting" & push
else no changes
Actions-->>Dev: no-op (skip commit)
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
LesnyRumcajs
force-pushed
the
auto-format-ci
branch
from
37ecffa to
0aacc5c
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/auto-format.yml:
- Around line 31-33: The workflow step currently invokes the Mise formatter with
the command "mise format" (action jdx/mise-action@v3); update that run command
to use "mise fmt" so it matches project docs and CONTRIBUTING.md/AGENTS.md
conventions, ensuring the workflow uses the documented formatter invocation.
- Around line 46-49: The workflow config sets git user.name ("git config
user.name \"LeshyBot\"") but omits user.email, causing commits to fail in CI;
update the auto-format job to set both git config user.name and git config
user.email (e.g., a LeshyBot email) before running git add/commit/push so
commits succeed in the auto-format step.
0aacc5c to
2acce58
Compare
Contributor
There was a problem hiding this comment.
♻️ Duplicate comments (2)
.github/workflows/auto-format.yml (2)
46-49:⚠️ Potential issue | 🔴 CriticalSet
git user.emailbefore committing.Line 46 sets only
user.name;git commitmay fail in CI without an email identity.Suggested patch
- name: Commit and push formatting changes if: steps.check-changes.outputs.has_changes == 'true' run: | git config user.name "LeshyBot" + git config user.email "leshybot@users.noreply.github.com" git add . git commit -m "[LeshyBot] Apply automatic formatting" git push#!/bin/bash # Verify git identity config present in this workflow segment. cat -n .github/workflows/auto-format.yml | sed -n '43,52p' rg -n 'git config user\.(name|email)' .github/workflows/auto-format.yml🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/auto-format.yml around lines 46 - 49, The workflow currently sets git config user.name "LeshyBot" but not user.email, which can make git commit fail in CI; modify the step that contains git config user.name "LeshyBot" and git commit -m "[LeshyBot] Apply automatic formatting" to also set git config user.email (e.g., use a noreply address derived from the actor or a repository bot email) before running git add/commit/push so Git has a complete committer identity.
31-33:⚠️ Potential issue | 🔴 CriticalUse
mise fmtinstead ofmise format.Line 32 uses
mise format, which can fail if the project task isfmt(and prevents the auto-fix workflow from doing its core job).Suggested patch
-# This workflow runs on every push and automatically applies formatting using mise format +# This workflow runs on every push and automatically applies formatting using mise fmt @@ - - run: mise format + - run: mise fmt#!/bin/bash # Verify formatter command conventions used by project docs and this workflow. find . -name "AGENTS.md" -type f -exec rg -n 'mise\s+(fmt|format)' {} + rg -n 'run:\s*mise\s+(fmt|format)' .github/workflows/auto-format.ymlBased on learnings: Run
mise fmtto format code before submission.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/auto-format.yml around lines 31 - 33, Replace the incorrect formatter command "mise format" with the project's canonical "mise fmt" in the CI workflow step that runs the jdx/mise-action; locate the job step using the action identifier jdx/mise-action@v3 and change the run command from "mise format" to "mise fmt" so the auto-format workflow calls the project's actual formatter task.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In @.github/workflows/auto-format.yml:
- Around line 46-49: The workflow currently sets git config user.name "LeshyBot"
but not user.email, which can make git commit fail in CI; modify the step that
contains git config user.name "LeshyBot" and git commit -m "[LeshyBot] Apply
automatic formatting" to also set git config user.email (e.g., use a noreply
address derived from the actor or a repository bot email) before running git
add/commit/push so Git has a complete committer identity.
- Around line 31-33: Replace the incorrect formatter command "mise format" with
the project's canonical "mise fmt" in the CI workflow step that runs the
jdx/mise-action; locate the job step using the action identifier
jdx/mise-action@v3 and change the run command from "mise format" to "mise fmt"
so the auto-format workflow calls the project's actual formatter task.
2acce58 to
c1609f7
Compare
Contributor
There was a problem hiding this comment.
♻️ Duplicate comments (2)
.github/workflows/auto-format.yml (2)
31-34:⚠️ Potential issue | 🟠 MajorUse
mise fmton Line 33.
mise formatis inconsistent with this repo’s formatter entrypoint and can fail when onlyfmtis defined.#!/bin/bash set -euo pipefail echo "=== Formatter command in workflow ===" rg -n 'mise (fmt|format)' .github/workflows/auto-format.yml echo echo "=== Repository guidance for mise formatter command ===" fd -HI 'AGENTS.md|CONTRIBUTING.md|README.md' | xargs -r rg -n 'mise (fmt|format)' echo echo "=== Mise task definitions (if present) ===" fd -HI 'mise.toml|.mise.toml' | xargs -r rg -n '(^\s*fmt\s*=|^\s*format\s*=|tasks\.(fmt|format))'Suggested patch
- - run: mise format + - run: mise fmtBased on learnings: Run
mise fmtto format code before submission.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/auto-format.yml around lines 31 - 34, The workflow step calls the wrong mise command: change the run step that invokes "mise format" to use the repository's canonical formatter entry "mise fmt"; locate the job that uses jdx/mise-action@v3 and replace the "run: mise format" step with "run: mise fmt" so the action uses the defined fmt task and avoids failures when only fmt is provided.
44-50:⚠️ Potential issue | 🔴 CriticalConfigure
git user.emailbefore commit.Lines 47-49 set only
user.name;git commitcan fail in CI without an email identity.#!/bin/bash set -euo pipefail echo "=== Identity and commit commands in auto-format workflow ===" rg -n 'git config user\.(name|email)|git commit' .github/workflows/auto-format.yml echo echo "=== Existing identity config patterns in other workflows ===" rg -n 'git config user\.(name|email)' .github/workflowsSuggested patch
- name: Commit and push formatting changes if: steps.check-changes.outputs.has_changes == 'true' run: | git config user.name "LeshyBot" + git config user.email "leshybot@users.noreply.github.com" git add . git commit -m "[LeshyBot] Apply automatic formatting" git push🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/auto-format.yml around lines 44 - 50, The workflow step "Commit and push formatting changes" sets git user.name but not user.email, which can cause git commit to fail in CI; update that step to configure both identity fields by adding a git config user.email line (use a CI-safe address like "leshybot@example.com" or the provided repo bot email) before git commit so commits succeed in non-interactive environments.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In @.github/workflows/auto-format.yml:
- Around line 31-34: The workflow step calls the wrong mise command: change the
run step that invokes "mise format" to use the repository's canonical formatter
entry "mise fmt"; locate the job that uses jdx/mise-action@v3 and replace the
"run: mise format" step with "run: mise fmt" so the action uses the defined fmt
task and avoids failures when only fmt is provided.
- Around line 44-50: The workflow step "Commit and push formatting changes" sets
git user.name but not user.email, which can cause git commit to fail in CI;
update that step to configure both identity fields by adding a git config
user.email line (use a CI-safe address like "leshybot@example.com" or the
provided repo bot email) before git commit so commits succeed in non-interactive
environments.
c1609f7 to
d8ae468
Compare
LesnyRumcajs
force-pushed
the
auto-format-ci
branch
from
d8ae468 to
b983a85
Compare
Member
Author
|
bailing, doesn't seem to be worth the overhead in the end |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 15 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Dependabot (or we) sometime push unformatted code; it's probably easier to just commit a fix from a bot than to wait for the CI to fail, notice it and run the format command yourself.
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit