Skip to content

chore: rm redundant binstall entry#6874

Merged
LesnyRumcajs merged 1 commit intomainfrom
rm-redundant-tool
Apr 8, 2026
Merged

chore: rm redundant binstall entry#6874
LesnyRumcajs merged 1 commit intomainfrom
rm-redundant-tool

Conversation

@LesnyRumcajs
Copy link
Copy Markdown
Member

@LesnyRumcajs LesnyRumcajs commented Apr 8, 2026

Summary of changes

we already have it for the entire project

cargo-binstall = "1.17"

Changes introduced in this pull request:

  • removed redundant binstall entry from task

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Chores
    • Updated development tooling configuration.

@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner April 8, 2026 12:06
@LesnyRumcajs LesnyRumcajs requested review from akaladarshi and hanabi1224 and removed request for a team April 8, 2026 12:06
@LesnyRumcajs LesnyRumcajs enabled auto-merge April 8, 2026 12:07
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 8, 2026

Walkthrough

The pull request removes the tools.cargo-binstall = "latest" line from the [tasks.install-lint-tools] task in mise.toml. The task's run command remains unchanged, relying on the broader cargo-binstall version configured elsewhere instead.

Changes

Cohort / File(s) Summary
Configuration
mise.toml
Removed tools.cargo-binstall = "latest" from [tasks.install-lint-tools] task definition, allowing cargo-binstall version to be determined by global tool configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • akaladarshi
  • hanabi1224
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: rm redundant binstall entry' accurately summarizes the main change—removing a redundant binstall configuration from mise.toml that duplicates project-level settings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rm-redundant-tool
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch rm-redundant-tool

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.02%. Comparing base (19d1045) to head (757ece2).
⚠️ Report is 7 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

see 20 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cfb27b...757ece2. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Apr 8, 2026
Merged via the queue into main with commit 72fd9ca Apr 8, 2026
47 checks passed
@LesnyRumcajs LesnyRumcajs deleted the rm-redundant-tool branch April 8, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants