CLI ignores OAuth client flags when a local API key is configured(AST-127635) #1409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cx-harshjeet-patil
requested review from
cx-anjali-deore,
cx-anurag-dalke and
cx-umesh-waghode
as code owners
|
Fixed Issues (3)Great job! The following issues were fixed in this Pull Request
|
internal/commands/root.go
Outdated
| log.SetOutput(multiWriter) | ||
| return nil | ||
| } | ||
| func CheckPreferredCredentials(cmd *cobra.Command) string { |
Contributor
There was a problem hiding this comment.
the return value of this method is redundant as its not used anywhere, method can be made void
Contributor
Author
There was a problem hiding this comment.
Changes have been made and pushed to the branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, you agree to the terms within the Checkmarx Code of Conduct. Please review the contributing guidelines for guidance on creating high-quality pull requests.
Description
If there's a configuration in CLI to access CxOne with an API key and an attempt is made to create a scan using OAuth client credentials, these credentials are not taken into account.
Type of Change
Related Issues
https://checkmarx.atlassian.net/browse/AST-127635
Checklist
Screenshots (if applicable)
Add screenshots to help explain your changes.
Additional Notes
Add any other relevant information.