Other/ast 128580 kics macos issue(AST-128580) #1423
+1,365
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aths and improve PATH handling
cx-amol-mane
requested review from
cx-anjali-deore,
cx-anurag-dalke and
cx-umesh-waghode
as code owners
|
Great job! No new security vulnerabilities introduced in this pull request |
… add related fields
…d maintainability
- Implement tests for the real ContainerManager, including ID generation and command creation. - Ensure unique container IDs and validate UUID format in tests. - Add tests for createCommandWithEnhancedPath to verify argument passing and environment variable settings. - Enhance tests for getFallbackPaths to check for duplicates and correct primary path ordering. - Introduce additional tests for verifyEnginePath and engineNameResolution functions to cover edge cases. - Expand tests for buildIgnoreMap and filterIgnoredFindings to ensure correct behavior with various inputs.
…pdate TestVerifyEnginePath to skip on non-Windows systems
…p non-existent paths
…h to ensure proper enhancement
…solved engine path and error. Update related tests to handle new return values accordingly.
…mage' instead of 'KICS Docker image' for consistency and clarity.
cx-anjali-deore
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, you agree to the terms within the Checkmarx Code of Conduct. Please review the contributing guidelines for guidance on creating high-quality pull requests.
Description
Please provide a summary of the changes and the related issue. Include relevant motivation and context.
Type of Change
Related Issues
Link any related issues or tickets.
Checklist
Screenshots (if applicable)
Add screenshots to help explain your changes.
Additional Notes
Add any other relevant information.