Open
Conversation
not-matthias
force-pushed
the
cod-2309-walltime-benchmarks-with-flamegraphs
branch
from
1e412cf to
cf6217a
Compare
There was a problem hiding this comment.
Pull request overview
Adds Java support for perf-based walltime profiling by configuring JVM frame pointers and perf map generation, auto-detecting Java commands for frame-pointer unwinding, and fixing env variable quoting for values with spaces.
Changes:
- Set
JAVA_TOOL_OPTIONSwith JVM flags for frame pointer preservation and perf map generation in walltime mode - Auto-select frame-pointer unwinding for gradle/java/maven commands in perf runner
- Quote environment variable values in the env file to handle spaces, and add
/proc/pid/mapsdebug logging
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/executor/helpers/env.rs | Adds JAVA_TOOL_OPTIONS env var for walltime mode |
| src/executor/wall_time/perf/mod.rs | Auto-detect Java commands for FP unwinding; add debug proc maps logging |
| src/executor/helpers/run_with_env.rs | Quote env values with single quotes in generated env file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
not-matthias
force-pushed
the
cod-2309-walltime-benchmarks-with-flamegraphs
branch
from
cf6217a to
56be8b1
Compare
Print the benchmark process memory map when CODSPEED_DEBUG is enabled. This helps with debugging missing symbols by showing which modules are loaded at which addresses.
not-matthias
force-pushed
the
cod-2309-walltime-benchmarks-with-flamegraphs
branch
from
56be8b1 to
710141a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.