Open
Conversation
maxn990
reviewed
Feb 14, 2026
Member
maxn990
left a comment
maxn990
left a comment
There was a problem hiding this comment.
Nice! I think you may have added slightly more padding/spacing than is on the figma, but otherwise looks really good. I just had a quick question too that I added in comments, but otherwise it looks really good!!
Comment on lines
70
to
72
| {alertMessage && ( | ||
| <FloatingAlert message={alertMessage} status="error" timeout={6000} /> | ||
| )} |
Member
There was a problem hiding this comment.
is there a reason this alert is in a portal and none of the others are?
Author
There was a problem hiding this comment.
Hey max! To be honest no reason, I moved it out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes https://vidushimisra.atlassian.net/jira/software/projects/SSF/boards/1?selectedIssue=SSF-124
📝 Description
This PR simply replaced native browser alerts with chakra alerts for better visuals. It only changes alerts that are on pages with updated designs according to the figma so some native alert() usages still exist but those will be updated when those pages get visually updated.
To make this change, I added a new reusable floatingAlert component
The routes effected are:
/admin-donation, /admin-order-management, /request-form/:pantryId
✔️ Verification
I verified each alert showed up as applicable.
🏕️ (Optional) Future Work / Notes
N/A