Fix down arrow key not working after font size change#364
Open
objectiveous wants to merge 2 commits intoCodeEditApp:mainfrom
Open
Fix down arrow key not working after font size change#364objectiveous wants to merge 2 commits intoCodeEditApp:mainfrom
objectiveous wants to merge 2 commits intoCodeEditApp:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After changing the font size, the down/up arrow keys stop moving the cursor across line boundaries. The root cause is that
TextViewLayoutManagercaches an estimated line height that isn't invalidated when the font changes. ThemoveDown:/moveUp:methods use this stale value to calculate the target point, which lands within the same line instead of the next one.Fix:
renderDelegateon the layout manager after font or line height multiplier changes, which forces the cached estimate to refresh.handleArrowKeydispatch so arrow keys with all modifier combinations (Shift, Option, Cmd) are handled correctly when the local event monitor intercepts them.Related Issues
Checklist