Skip to content

fix: remove legacy DataTable class and hide pagination options when disabled#1271

Open
HardeepAsrani wants to merge 1 commit intodevelopmentfrom
fix/issue-532
Open

fix: remove legacy DataTable class and hide pagination options when disabled#1271
HardeepAsrani wants to merge 1 commit intodevelopmentfrom
fix/issue-532

Conversation

@HardeepAsrani
Copy link
Member

@HardeepAsrani HardeepAsrani commented Mar 10, 2026

Summary

  • Delete Visualizer_Render_Sidebar_Type_DataTable_DataTable (backward compat stub no longer needed; upgrade routine handles DB migration)
  • Remove the now-redundant class name redirect in Module::load_chart_type()
  • Hide pagination-dependent fields (rows per page, pagination type) in both DataTable/Tabular and GoogleCharts/Tabular sidebars when pagination is disabled; toggle visibility via JS on checkbox change
  • Update phpstan baseline and add memory-limit/reportUnmatchedIgnoredErrors

Pro PR: https://github.com/Codeinwp/visualizer-pro/compare/development...fix/issue-532?expand=1

Will affect visual aspect of the product

YES/NO

Screenshots

Test instructions

  • Make sure the pagination options don't appear if the options are disabled.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/visualizer-pro/issues/532.

…isabled

- Delete Visualizer_Render_Sidebar_Type_DataTable_DataTable (backward
  compat stub no longer needed; upgrade routine handles DB migration)
- Remove the now-redundant class name redirect in Module::load_chart_type()
- Hide pagination-dependent fields (rows per page, pagination type) in
  both DataTable/Tabular and GoogleCharts/Tabular sidebars when pagination
  is disabled; toggle visibility via JS on checkbox change
- Update phpstan baseline and add memory-limit/reportUnmatchedIgnoredErrors
@HardeepAsrani HardeepAsrani added the pr-checklist-skip Allow this Pull Request to skip checklist. label Mar 10, 2026
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Mar 10, 2026
@pirate-bot
Copy link
Contributor

Plugin build for ba1f39a is ready 🛎️!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants