Skip to content

Conversation

@Mehrn0ush
Copy link
Contributor

As discussed in ticket #763, this PR adds AES-SIV (RFC 5297) as an AEAD variant to the Cryptography Registry.

Fixes #763

Details

  • Adds AES[-(128|192|256)]-SIV as an ae variant under the existing AES family.
  • Adds authoritative standards reference for RFC 5297.
  • Registry-only change (schema/cryptography-defs.json). No schema or specification behavior changes.

@Mehrn0ush Mehrn0ush requested a review from a team as a code owner January 6, 2026 13:18
@stevespringett stevespringett added cap: cryptography Capability: Cryptography (CBOM) cap: cryptography-registry Capability: Cryptography Registry labels Jan 8, 2026
@stevespringett
Copy link
Member

@bhess

Copy link
Contributor

@bhess bhess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds AES-SIV (Synthetic Initialization Vector) as a new AEAD variant to the cryptography registry, addressing issue #763. AES-SIV is defined in RFC 5297 and provides deterministic authenticated encryption with associated data (AEAD).

Changes:

  • Adds AES-SIV variant with support for 128, 192, and 256-bit key sizes
  • Includes authoritative RFC 5297 standard reference with DOI URL
  • Classified as an authenticated encryption (ae) primitive within the AES algorithm family

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

stevespringett
stevespringett previously approved these changes Jan 15, 2026
@Mehrn0ush
Copy link
Contributor Author

Fixed — normalized to RFC5297 for consistency across the registry.

stevespringett
stevespringett previously approved these changes Jan 22, 2026
@stevespringett
Copy link
Member

Thanks again for the PR. Once merge conflicts are resolved, I can go ahead and merge this in. Thanks again.

@Mehrn0ush
Copy link
Contributor Author

Conflicts are now resolved and the branch has been rebased onto the latest upstream/master.

AES-SIV (RFC5297) is correctly registered under the AES AEAD family and RFC naming has been normalized for consistency. DCO sign-off is preserved.

Thanks again for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cap: cryptography Capability: Cryptography (CBOM) cap: cryptography-registry Capability: Cryptography Registry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Add AES-SIV (RFC 5297) AEAD variant to Cryptography Registry

3 participants