Migrate enveloped signature support from JSF to JSS#858
Migrate enveloped signature support from JSF to JSS#858stevespringett wants to merge 1 commit into2.0-devfrom
Conversation
… number of valid and invalid use cases. Signed-off-by: Steve Springett <steve@springett.us>
j28smith
left a comment
j28smith
left a comment
There was a problem hiding this comment.
I took a quick look at this @stevespringett and it looks good at a high level. I noted a number of places where the descriptions still reference JSF instead of the updated JSS.
For the core change/update, is this the main file to look more closely at to ensure it references the JSS spec correctly?
schema/2.0/model/cyclonedx-jss_X590_2023_10-2.0.schema.json
| "signatures": { | ||
| "$ref": "cyclonedx-common-2.0.schema.json#/$defs/signatures", | ||
| "title": "Signature", | ||
| "description": "Enveloped signature in [JSON Signature Format (JSF)](https://cyberphone.github.io/doc/security/jsf.html)." |
There was a problem hiding this comment.
Need to update the description here.
"description": "Enveloped signatures in [JSON Signature Scheme (JSS/ITU-T X.590)](https://www.itu.int/epublications/publication/itu-t-x-590-2023-10-json-signature-scheme-jss)."
| "signatures": { | ||
| "$ref": "cyclonedx-common-2.0.schema.json#/$defs/signatures", | ||
| "title": "Signature", | ||
| "description": "Enveloped signature in [JSON Signature Format (JSF)](https://cyberphone.github.io/doc/security/jsf.html)." |
There was a problem hiding this comment.
Need to update the description here.
"description": "Enveloped signatures in [JSON Signature Scheme (JSS/ITU-T X.590)](https://www.itu.int/epublications/publication/itu-t-x-590-2023-10-json-signature-scheme-jss)."
| "signatures": { | ||
| "$ref": "cyclonedx-common-2.0.schema.json#/$defs/signatures", | ||
| "title": "Signature", | ||
| "description": "Enveloped signature in [JSON Signature Format (JSF)](https://cyberphone.github.io/doc/security/jsf.html)." |
There was a problem hiding this comment.
Need to update the description here.
"description": "Enveloped signatures in [JSON Signature Scheme (JSS/ITU-T X.590)](https://www.itu.int/epublications/publication/itu-t-x-590-2023-10-json-signature-scheme-jss)."
| "signatures": { | ||
| "$ref": "cyclonedx-common-2.0.schema.json#/$defs/signatures", | ||
| "title": "Signature", | ||
| "description": "Enveloped signature in [JSON Signature Format (JSF)](https://cyberphone.github.io/doc/security/jsf.html)." |
There was a problem hiding this comment.
Need to update the description here.
"description": "Enveloped signatures in [JSON Signature Scheme (JSS/ITU-T X.590)](https://www.itu.int/epublications/publication/itu-t-x-590-2023-10-json-signature-scheme-jss)."
| "signatures": { | ||
| "$ref": "cyclonedx-common-2.0.schema.json#/$defs/signatures", | ||
| "title": "Signature", | ||
| "description": "Enveloped signature in [JSON Signature Format (JSF)](https://cyberphone.github.io/doc/security/jsf.html)." |
There was a problem hiding this comment.
Need to update the description here.
"description": "Enveloped signatures in [JSON Signature Scheme (JSS/ITU-T X.590)](https://www.itu.int/epublications/publication/itu-t-x-590-2023-10-json-signature-scheme-jss)."
| "signatures": { | ||
| "$ref": "cyclonedx-common-2.0.schema.json#/$defs/signatures", | ||
| "title": "Signature", | ||
| "description": "Enveloped signature in [JSON Signature Format (JSF)](https://cyberphone.github.io/doc/security/jsf.html)." |
There was a problem hiding this comment.
Need to update the description here.
"description": "Enveloped signatures in [JSON Signature Scheme (JSS/ITU-T X.590)](https://www.itu.int/epublications/publication/itu-t-x-590-2023-10-json-signature-scheme-jss)."
| "signatures": { | ||
| "$ref": "cyclonedx-common-2.0.schema.json#/$defs/signatures", | ||
| "title": "Signature", | ||
| "description": "Enveloped signature in [JSON Signature Format (JSF)](https://cyberphone.github.io/doc/security/jsf.html)." |
There was a problem hiding this comment.
Need to update the description here.
"description": "Enveloped signatures in [JSON Signature Scheme (JSS/ITU-T X.590)](https://www.itu.int/epublications/publication/itu-t-x-590-2023-10-json-signature-scheme-jss)."
| "signatures": { | ||
| "$ref": "cyclonedx-common-2.0.schema.json#/$defs/signatures", | ||
| "title": "Signature", | ||
| "description": "Enveloped signature in [JSON Signature Format (JSF)](https://cyberphone.github.io/doc/security/jsf.html)." |
There was a problem hiding this comment.
Need to update the description here.
"description": "Enveloped signatures in [JSON Signature Scheme (JSS/ITU-T X.590)](https://www.itu.int/epublications/publication/itu-t-x-590-2023-10-json-signature-scheme-jss)."
| "signatures": { | ||
| "$ref": "cyclonedx-common-2.0.schema.json#/$defs/signatures", | ||
| "title": "Signature", | ||
| "description": "Enveloped signature in [JSON Signature Format (JSF)](https://cyberphone.github.io/doc/security/jsf.html)." |
There was a problem hiding this comment.
Need to update the description here.
"description": "Enveloped signatures in [JSON Signature Scheme (JSS/ITU-T X.590)](https://www.itu.int/epublications/publication/itu-t-x-590-2023-10-json-signature-scheme-jss)."
| "signatures": { | ||
| "$ref": "cyclonedx-common-2.0.schema.json#/$defs/signatures", | ||
| "title": "Signature", | ||
| "description": "Enveloped signature in [JSON Signature Format (JSF)](https://cyberphone.github.io/doc/security/jsf.html)." |
There was a problem hiding this comment.
Need to update the description here.
"description": "Enveloped signatures in [JSON Signature Scheme (JSS/ITU-T X.590)](https://www.itu.int/epublications/publication/itu-t-x-590-2023-10-json-signature-scheme-jss)."
2 participants
Migrate enveloped signature support from JSF to JSS (ITU-T X.590)
Summary
signaturesarray (JSS) instead of singularsignatureobject (JSF)valid-signatures-2.0.json) and added 18 targeted JSS test cases (8 valid, 10 invalid)This PR closes #851
All tests are structural validations only. Keys, certificates, thumbprints, and signature values are illustrative and may not be cryptographically valid. No content validation is performed.