-
Notifications
You must be signed in to change notification settings - Fork 324
🪞 9979 - Instrumentation test error visibility #10300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This puts the details front and center in the test summary and is much easier than hunting back through log messages. Note: In InstrumentationErrors, errors are only recorded when enableRecordingAndReset has been called. This is only done from the InstrumentationSpecification test specification, so we don't need to worry about the ArrayList growing without bounds in production. I considered adding a limit to the ArrayList, but opted not to for simplicity. I also wanted to avoid silently discarding some errors.
If there is a blocked instrumentation, the test will fail and the failure message will include the same information that is logged from MuzzleCheck.
|
Created this to mainly run CI checks - there are a couple of things to clean up before this can be merged. |
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~7e9999d5d1, baseline=1.59.0-SNAPSHOT~6f47da29ddf
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.087 s) : 0, 1087076
Total [baseline] (8.776 s) : 0, 8775911
Agent [candidate] (1.094 s) : 0, 1094204
Total [candidate] (8.798 s) : 0, 8798191
section iast
Agent [baseline] (1.236 s) : 0, 1236480
Total [baseline] (9.394 s) : 0, 9394389
Agent [candidate] (1.23 s) : 0, 1230197
Total [candidate] (9.381 s) : 0, 9380914
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~7e9999d5d1, baseline=1.59.0-SNAPSHOT~6f47da29ddf
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (653.133 ms) : 0, 653133
BytebuddyAgent [candidate] (657.338 ms) : 0, 657338
GlobalTracer [baseline] (283.54 ms) : 0, 283540
GlobalTracer [candidate] (285.561 ms) : 0, 285561
AppSec [baseline] (32.603 ms) : 0, 32603
AppSec [candidate] (32.979 ms) : 0, 32979
Debugger [baseline] (65.972 ms) : 0, 65972
Debugger [candidate] (67.255 ms) : 0, 67255
Remote Config [baseline] (621.431 µs) : 0, 621
Remote Config [candidate] (626.001 µs) : 0, 626
Telemetry [baseline] (8.882 ms) : 0, 8882
Telemetry [candidate] (8.892 ms) : 0, 8892
Flare Poller [baseline] (5.354 ms) : 0, 5354
Flare Poller [candidate] (4.61 ms) : 0, 4610
section iast
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (801.437 ms) : 0, 801437
BytebuddyAgent [candidate] (796.271 ms) : 0, 796271
GlobalTracer [baseline] (258.829 ms) : 0, 258829
GlobalTracer [candidate] (258.294 ms) : 0, 258294
AppSec [baseline] (33.557 ms) : 0, 33557
AppSec [candidate] (34.244 ms) : 0, 34244
Debugger [baseline] (66.357 ms) : 0, 66357
Debugger [candidate] (65.133 ms) : 0, 65133
Remote Config [baseline] (555.039 µs) : 0, 555
Remote Config [candidate] (565.5 µs) : 0, 565
Telemetry [baseline] (8.379 ms) : 0, 8379
Telemetry [candidate] (8.457 ms) : 0, 8457
Flare Poller [baseline] (3.531 ms) : 0, 3531
Flare Poller [candidate] (3.626 ms) : 0, 3626
IAST [baseline] (26.993 ms) : 0, 26993
IAST [candidate] (26.971 ms) : 0, 26971
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~7e9999d5d1, baseline=1.59.0-SNAPSHOT~6f47da29ddf
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.094 s) : 0, 1094050
Total [baseline] (11.018 s) : 0, 11018206
Agent [candidate] (1.092 s) : 0, 1092131
Total [candidate] (11.015 s) : 0, 11014655
section appsec
Agent [baseline] (1.275 s) : 0, 1275467
Total [baseline] (10.979 s) : 0, 10978666
Agent [candidate] (1.286 s) : 0, 1285637
Total [candidate] (11.224 s) : 0, 11224422
section iast
Agent [baseline] (1.227 s) : 0, 1227287
Total [baseline] (11.193 s) : 0, 11193402
Agent [candidate] (1.23 s) : 0, 1230272
Total [candidate] (11.248 s) : 0, 11248292
section profiling
Agent [baseline] (1.216 s) : 0, 1216034
Total [baseline] (10.98 s) : 0, 10980474
Agent [candidate] (1.217 s) : 0, 1216910
Total [candidate] (10.954 s) : 0, 10954267
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~7e9999d5d1, baseline=1.59.0-SNAPSHOT~6f47da29ddf
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.205 ms) : 0, 1205
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (656.172 ms) : 0, 656172
BytebuddyAgent [candidate] (655.728 ms) : 0, 655728
GlobalTracer [baseline] (285.682 ms) : 0, 285682
GlobalTracer [candidate] (284.835 ms) : 0, 284835
AppSec [baseline] (32.672 ms) : 0, 32672
AppSec [candidate] (32.706 ms) : 0, 32706
Debugger [baseline] (69.049 ms) : 0, 69049
Debugger [candidate] (68.592 ms) : 0, 68592
Remote Config [baseline] (642.628 µs) : 0, 643
Remote Config [candidate] (641.81 µs) : 0, 642
Telemetry [baseline] (8.906 ms) : 0, 8906
Telemetry [candidate] (8.886 ms) : 0, 8886
Flare Poller [baseline] (3.911 ms) : 0, 3911
Flare Poller [candidate] (3.837 ms) : 0, 3837
section appsec
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.224 ms) : 0, 1224
BytebuddyAgent [baseline] (696.85 ms) : 0, 696850
BytebuddyAgent [candidate] (702.157 ms) : 0, 702157
GlobalTracer [baseline] (261.535 ms) : 0, 261535
GlobalTracer [candidate] (263.406 ms) : 0, 263406
AppSec [baseline] (174.533 ms) : 0, 174533
AppSec [candidate] (173.518 ms) : 0, 173518
Debugger [baseline] (66.894 ms) : 0, 66894
Debugger [candidate] (70.417 ms) : 0, 70417
Remote Config [baseline] (807.793 µs) : 0, 808
Remote Config [candidate] (772.82 µs) : 0, 773
Telemetry [baseline] (9.386 ms) : 0, 9386
Telemetry [candidate] (9.417 ms) : 0, 9417
Flare Poller [baseline] (3.668 ms) : 0, 3668
Flare Poller [candidate] (3.775 ms) : 0, 3775
IAST [baseline] (24.894 ms) : 0, 24894
IAST [candidate] (25.054 ms) : 0, 25054
section iast
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (793.644 ms) : 0, 793644
BytebuddyAgent [candidate] (795.79 ms) : 0, 795790
GlobalTracer [baseline] (257.388 ms) : 0, 257388
GlobalTracer [candidate] (257.954 ms) : 0, 257954
AppSec [baseline] (32.723 ms) : 0, 32723
AppSec [candidate] (34.31 ms) : 0, 34310
Debugger [baseline] (67.443 ms) : 0, 67443
Debugger [candidate] (65.784 ms) : 0, 65784
Remote Config [baseline] (606.574 µs) : 0, 607
Remote Config [candidate] (575.841 µs) : 0, 576
Telemetry [baseline] (8.447 ms) : 0, 8447
Telemetry [candidate] (8.481 ms) : 0, 8481
Flare Poller [baseline] (3.573 ms) : 0, 3573
Flare Poller [candidate] (3.588 ms) : 0, 3588
IAST [baseline] (26.909 ms) : 0, 26909
IAST [candidate] (27.125 ms) : 0, 27125
section profiling
crashtracking [baseline] (1.233 ms) : 0, 1233
crashtracking [candidate] (1.228 ms) : 0, 1228
BytebuddyAgent [baseline] (707.988 ms) : 0, 707988
BytebuddyAgent [candidate] (708.93 ms) : 0, 708930
GlobalTracer [baseline] (223.454 ms) : 0, 223454
GlobalTracer [candidate] (223.569 ms) : 0, 223569
AppSec [baseline] (32.633 ms) : 0, 32633
AppSec [candidate] (32.786 ms) : 0, 32786
Debugger [baseline] (68.706 ms) : 0, 68706
Debugger [candidate] (68.576 ms) : 0, 68576
Remote Config [baseline] (658.548 µs) : 0, 659
Remote Config [candidate] (678.069 µs) : 0, 678
Telemetry [baseline] (8.977 ms) : 0, 8977
Telemetry [candidate] (8.992 ms) : 0, 8992
Flare Poller [baseline] (3.783 ms) : 0, 3783
Flare Poller [candidate] (3.728 ms) : 0, 3728
ProfilingAgent [baseline] (98.239 ms) : 0, 98239
ProfilingAgent [candidate] (98.042 ms) : 0, 98042
Profiling [baseline] (98.824 ms) : 0, 98824
Profiling [candidate] (98.633 ms) : 0, 98633
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 14 metrics, 19 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~7e9999d5d1, baseline=1.59.0-SNAPSHOT~6f47da29ddf
dateFormat X
axisFormat %s
section baseline
no_agent (1.198 ms) : 1186, 1210
. : milestone, 1198,
iast (3.032 ms) : 2997, 3067
. : milestone, 3032,
iast_FULL (5.864 ms) : 5804, 5923
. : milestone, 5864,
iast_GLOBAL (3.748 ms) : 3688, 3809
. : milestone, 3748,
profiling (2.107 ms) : 2088, 2127
. : milestone, 2107,
tracing (1.793 ms) : 1779, 1808
. : milestone, 1793,
section candidate
no_agent (1.174 ms) : 1162, 1187
. : milestone, 1174,
iast (3.185 ms) : 3140, 3230
. : milestone, 3185,
iast_FULL (5.69 ms) : 5633, 5747
. : milestone, 5690,
iast_GLOBAL (3.721 ms) : 3659, 3783
. : milestone, 3721,
profiling (2.147 ms) : 2127, 2167
. : milestone, 2147,
tracing (1.815 ms) : 1799, 1831
. : milestone, 1815,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~7e9999d5d1, baseline=1.59.0-SNAPSHOT~6f47da29ddf
dateFormat X
axisFormat %s
section baseline
no_agent (18.196 ms) : 18009, 18382
. : milestone, 18196,
appsec (19.503 ms) : 19303, 19702
. : milestone, 19503,
code_origins (17.892 ms) : 17710, 18075
. : milestone, 17892,
iast (17.576 ms) : 17401, 17751
. : milestone, 17576,
profiling (18.453 ms) : 18268, 18637
. : milestone, 18453,
tracing (17.883 ms) : 17705, 18060
. : milestone, 17883,
section candidate
no_agent (18.076 ms) : 17887, 18264
. : milestone, 18076,
appsec (20.423 ms) : 20221, 20626
. : milestone, 20423,
code_origins (18.605 ms) : 18417, 18793
. : milestone, 18605,
iast (17.731 ms) : 17556, 17905
. : milestone, 17731,
profiling (18.55 ms) : 18364, 18736
. : milestone, 18550,
tracing (18.561 ms) : 18374, 18748
. : milestone, 18561,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~7e9999d5d1, baseline=1.59.0-SNAPSHOT~6f47da29ddf
dateFormat X
axisFormat %s
section baseline
no_agent (1.483 ms) : 1471, 1494
. : milestone, 1483,
appsec (3.733 ms) : 3512, 3954
. : milestone, 3733,
iast (2.219 ms) : 2154, 2284
. : milestone, 2219,
iast_GLOBAL (2.265 ms) : 2199, 2330
. : milestone, 2265,
profiling (2.064 ms) : 2011, 2116
. : milestone, 2064,
tracing (2.063 ms) : 2012, 2114
. : milestone, 2063,
section candidate
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (3.757 ms) : 3534, 3980
. : milestone, 3757,
iast (2.222 ms) : 2156, 2287
. : milestone, 2222,
iast_GLOBAL (2.265 ms) : 2200, 2331
. : milestone, 2265,
profiling (2.101 ms) : 2046, 2156
. : milestone, 2101,
tracing (2.057 ms) : 2006, 2108
. : milestone, 2057,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~7e9999d5d1, baseline=1.59.0-SNAPSHOT~6f47da29ddf
dateFormat X
axisFormat %s
section baseline
no_agent (14.807 s) : 14807000, 14807000
. : milestone, 14807000,
appsec (14.731 s) : 14731000, 14731000
. : milestone, 14731000,
iast (18.161 s) : 18161000, 18161000
. : milestone, 18161000,
iast_GLOBAL (17.834 s) : 17834000, 17834000
. : milestone, 17834000,
profiling (15.146 s) : 15146000, 15146000
. : milestone, 15146000,
tracing (14.624 s) : 14624000, 14624000
. : milestone, 14624000,
section candidate
no_agent (15.073 s) : 15073000, 15073000
. : milestone, 15073000,
appsec (15.052 s) : 15052000, 15052000
. : milestone, 15052000,
iast (18.396 s) : 18396000, 18396000
. : milestone, 18396000,
iast_GLOBAL (17.755 s) : 17755000, 17755000
. : milestone, 17755000,
profiling (14.825 s) : 14825000, 14825000
. : milestone, 14825000,
tracing (14.671 s) : 14671000, 14671000
. : milestone, 14671000,
|
This PR mirrors the changes from the original community contribution to enable CI testing with maintainer privileges.
Original PR: #9979
Original Author: @deejgregor
Original Branch: deejgregor/dd-trace-java:feature-instrumentation-test-error-visibility
Closes #9979
This is an automated mirror created to run CI checks. See tooling/mirror-community-pull-request.sh for details.