-
Notifications
You must be signed in to change notification settings - Fork 324
WIP #10393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jandro996
wants to merge
4
commits into
master
Choose a base branch
from
alejandro.gonzalez/add-apm-trace-metrics-tags
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP #10393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~8fccf33fe7, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.098 s) : 0, 1098397
Total [baseline] (10.817 s) : 0, 10817185
Agent [candidate] (1.09 s) : 0, 1089560
Total [candidate] (10.891 s) : 0, 10891346
section appsec
Agent [baseline] (1.266 s) : 0, 1266276
Total [baseline] (11.094 s) : 0, 11093513
Agent [candidate] (1.266 s) : 0, 1266157
Total [candidate] (11.081 s) : 0, 11081335
section iast
Agent [baseline] (1.225 s) : 0, 1224707
Total [baseline] (11.222 s) : 0, 11222395
Agent [candidate] (1.236 s) : 0, 1236300
Total [candidate] (11.294 s) : 0, 11294442
section profiling
Agent [baseline] (1.206 s) : 0, 1206260
Total [baseline] (10.916 s) : 0, 10916477
Agent [candidate] (1.205 s) : 0, 1205204
Total [candidate] (10.849 s) : 0, 10848578
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~8fccf33fe7, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.216 ms) : 0, 1216
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (659.865 ms) : 0, 659865
BytebuddyAgent [candidate] (653.198 ms) : 0, 653198
GlobalTracer [baseline] (285.621 ms) : 0, 285621
GlobalTracer [candidate] (284.659 ms) : 0, 284659
AppSec [baseline] (33.151 ms) : 0, 33151
AppSec [candidate] (32.744 ms) : 0, 32744
Debugger [baseline] (69.106 ms) : 0, 69106
Debugger [candidate] (68.548 ms) : 0, 68548
Remote Config [baseline] (653.728 µs) : 0, 654
Remote Config [candidate] (647.541 µs) : 0, 648
Telemetry [baseline] (9.004 ms) : 0, 9004
Telemetry [candidate] (9.038 ms) : 0, 9038
Flare Poller [baseline] (3.847 ms) : 0, 3847
Flare Poller [candidate] (3.858 ms) : 0, 3858
section appsec
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (690.481 ms) : 0, 690481
BytebuddyAgent [candidate] (691.548 ms) : 0, 691548
GlobalTracer [baseline] (258.433 ms) : 0, 258433
GlobalTracer [candidate] (258.645 ms) : 0, 258645
AppSec [baseline] (174.048 ms) : 0, 174048
AppSec [candidate] (173.324 ms) : 0, 173324
Debugger [baseline] (68.076 ms) : 0, 68076
Debugger [candidate] (67.325 ms) : 0, 67325
Remote Config [baseline] (753.391 µs) : 0, 753
Remote Config [candidate] (799.984 µs) : 0, 800
Telemetry [baseline] (9.359 ms) : 0, 9359
Telemetry [candidate] (9.412 ms) : 0, 9412
Flare Poller [baseline] (3.782 ms) : 0, 3782
Flare Poller [candidate] (3.759 ms) : 0, 3759
IAST [baseline] (24.572 ms) : 0, 24572
IAST [candidate] (24.626 ms) : 0, 24626
section iast
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.174 ms) : 0, 1174
BytebuddyAgent [baseline] (791.604 ms) : 0, 791604
BytebuddyAgent [candidate] (797.959 ms) : 0, 797959
GlobalTracer [baseline] (256.99 ms) : 0, 256990
GlobalTracer [candidate] (259.798 ms) : 0, 259798
AppSec [baseline] (35.154 ms) : 0, 35154
AppSec [candidate] (35.84 ms) : 0, 35840
Debugger [baseline] (64.812 ms) : 0, 64812
Debugger [candidate] (65.603 ms) : 0, 65603
Remote Config [baseline] (585.768 µs) : 0, 586
Remote Config [candidate] (606.072 µs) : 0, 606
Telemetry [baseline] (8.417 ms) : 0, 8417
Telemetry [candidate] (8.701 ms) : 0, 8701
Flare Poller [baseline] (3.55 ms) : 0, 3550
Flare Poller [candidate] (3.646 ms) : 0, 3646
IAST [baseline] (26.976 ms) : 0, 26976
IAST [candidate] (27.46 ms) : 0, 27460
section profiling
crashtracking [baseline] (1.228 ms) : 0, 1228
crashtracking [candidate] (1.23 ms) : 0, 1230
BytebuddyAgent [baseline] (702.532 ms) : 0, 702532
BytebuddyAgent [candidate] (701.637 ms) : 0, 701637
GlobalTracer [baseline] (221.102 ms) : 0, 221102
GlobalTracer [candidate] (221.408 ms) : 0, 221408
AppSec [baseline] (32.178 ms) : 0, 32178
AppSec [candidate] (32.064 ms) : 0, 32064
Debugger [baseline] (68.722 ms) : 0, 68722
Debugger [candidate] (68.499 ms) : 0, 68499
Remote Config [baseline] (649.337 µs) : 0, 649
Remote Config [candidate] (648.099 µs) : 0, 648
Telemetry [baseline] (9.041 ms) : 0, 9041
Telemetry [candidate] (8.907 ms) : 0, 8907
Flare Poller [baseline] (3.766 ms) : 0, 3766
Flare Poller [candidate] (3.744 ms) : 0, 3744
ProfilingAgent [baseline] (97.079 ms) : 0, 97079
ProfilingAgent [candidate] (97.158 ms) : 0, 97158
Profiling [baseline] (97.664 ms) : 0, 97664
Profiling [candidate] (97.735 ms) : 0, 97735
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~8fccf33fe7, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.101 s) : 0, 1101286
Total [baseline] (8.798 s) : 0, 8797682
Agent [candidate] (1.087 s) : 0, 1086563
Total [candidate] (8.775 s) : 0, 8774822
section iast
Agent [baseline] (1.236 s) : 0, 1235513
Total [baseline] (9.382 s) : 0, 9381552
Agent [candidate] (1.225 s) : 0, 1225346
Total [candidate] (9.328 s) : 0, 9327947
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~8fccf33fe7, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.219 ms) : 0, 1219
crashtracking [candidate] (1.17 ms) : 0, 1170
BytebuddyAgent [baseline] (662.774 ms) : 0, 662774
BytebuddyAgent [candidate] (652.586 ms) : 0, 652586
GlobalTracer [baseline] (286.769 ms) : 0, 286769
GlobalTracer [candidate] (283.882 ms) : 0, 283882
AppSec [baseline] (32.977 ms) : 0, 32977
AppSec [candidate] (32.763 ms) : 0, 32763
Debugger [baseline] (67.884 ms) : 0, 67884
Debugger [candidate] (67.137 ms) : 0, 67137
Remote Config [baseline] (696.932 µs) : 0, 697
Remote Config [candidate] (638.642 µs) : 0, 639
Telemetry [baseline] (9.146 ms) : 0, 9146
Telemetry [candidate] (8.992 ms) : 0, 8992
Flare Poller [baseline] (3.831 ms) : 0, 3831
Flare Poller [candidate] (3.854 ms) : 0, 3854
section iast
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.176 ms) : 0, 1176
BytebuddyAgent [baseline] (799.955 ms) : 0, 799955
BytebuddyAgent [candidate] (792.641 ms) : 0, 792641
GlobalTracer [baseline] (258.791 ms) : 0, 258791
GlobalTracer [candidate] (256.785 ms) : 0, 256785
AppSec [baseline] (33.871 ms) : 0, 33871
AppSec [candidate] (35.275 ms) : 0, 35275
Debugger [baseline] (65.959 ms) : 0, 65959
Debugger [candidate] (64.338 ms) : 0, 64338
Remote Config [baseline] (574.131 µs) : 0, 574
Remote Config [candidate] (571.714 µs) : 0, 572
Telemetry [baseline] (8.546 ms) : 0, 8546
Telemetry [candidate] (8.524 ms) : 0, 8524
Flare Poller [baseline] (3.611 ms) : 0, 3611
Flare Poller [candidate] (3.648 ms) : 0, 3648
IAST [baseline] (27.22 ms) : 0, 27220
IAST [candidate] (26.82 ms) : 0, 26820
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 20 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~8fccf33fe7, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section baseline
no_agent (1.173 ms) : 1161, 1184
. : milestone, 1173,
iast (3.107 ms) : 3068, 3146
. : milestone, 3107,
iast_FULL (5.605 ms) : 5550, 5661
. : milestone, 5605,
iast_GLOBAL (3.451 ms) : 3399, 3503
. : milestone, 3451,
profiling (1.994 ms) : 1977, 2012
. : milestone, 1994,
tracing (1.801 ms) : 1787, 1815
. : milestone, 1801,
section candidate
no_agent (1.28 ms) : 1268, 1293
. : milestone, 1280,
iast (3.122 ms) : 3084, 3159
. : milestone, 3122,
iast_FULL (5.539 ms) : 5486, 5593
. : milestone, 5539,
iast_GLOBAL (3.449 ms) : 3400, 3497
. : milestone, 3449,
profiling (1.905 ms) : 1887, 1922
. : milestone, 1905,
tracing (1.81 ms) : 1795, 1826
. : milestone, 1810,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~8fccf33fe7, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section baseline
no_agent (17.261 ms) : 17085, 17437
. : milestone, 17261,
appsec (18.955 ms) : 18767, 19143
. : milestone, 18955,
code_origins (17.559 ms) : 17389, 17730
. : milestone, 17559,
iast (18.176 ms) : 17997, 18354
. : milestone, 18176,
profiling (19.486 ms) : 19286, 19686
. : milestone, 19486,
tracing (17.693 ms) : 17515, 17870
. : milestone, 17693,
section candidate
no_agent (17.187 ms) : 17013, 17360
. : milestone, 17187,
appsec (18.624 ms) : 18433, 18816
. : milestone, 18624,
code_origins (17.752 ms) : 17576, 17928
. : milestone, 17752,
iast (17.944 ms) : 17764, 18124
. : milestone, 17944,
profiling (18.673 ms) : 18486, 18859
. : milestone, 18673,
tracing (17.819 ms) : 17640, 17998
. : milestone, 17819,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~8fccf33fe7, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section baseline
no_agent (15.598 s) : 15598000, 15598000
. : milestone, 15598000,
appsec (14.426 s) : 14426000, 14426000
. : milestone, 14426000,
iast (17.92 s) : 17920000, 17920000
. : milestone, 17920000,
iast_GLOBAL (18.111 s) : 18111000, 18111000
. : milestone, 18111000,
profiling (14.932 s) : 14932000, 14932000
. : milestone, 14932000,
tracing (14.796 s) : 14796000, 14796000
. : milestone, 14796000,
section candidate
no_agent (15.343 s) : 15343000, 15343000
. : milestone, 15343000,
appsec (14.955 s) : 14955000, 14955000
. : milestone, 14955000,
iast (18.524 s) : 18524000, 18524000
. : milestone, 18524000,
iast_GLOBAL (17.884 s) : 17884000, 17884000
. : milestone, 17884000,
profiling (14.938 s) : 14938000, 14938000
. : milestone, 14938000,
tracing (14.676 s) : 14676000, 14676000
. : milestone, 14676000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~8fccf33fe7, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.615 ms) : 3403, 3827
. : milestone, 3615,
iast (2.227 ms) : 2161, 2292
. : milestone, 2227,
iast_GLOBAL (2.264 ms) : 2199, 2330
. : milestone, 2264,
profiling (2.081 ms) : 2028, 2134
. : milestone, 2081,
tracing (2.062 ms) : 2010, 2114
. : milestone, 2062,
section candidate
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (3.724 ms) : 3504, 3944
. : milestone, 3724,
iast (2.222 ms) : 2156, 2287
. : milestone, 2222,
iast_GLOBAL (2.27 ms) : 2203, 2336
. : milestone, 2270,
profiling (2.082 ms) : 2028, 2136
. : milestone, 2082,
tracing (2.047 ms) : 1995, 2099
. : milestone, 2047,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: asm waf
Application Security Management (WAF)
tag: do not merge
Do not merge changes
type: enhancement
Enhancements and improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]