-
Notifications
You must be signed in to change notification settings - Fork 324
fix(llmobs): trace batching and payload size telemetry #10395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ygree
wants to merge
3
commits into
master
Choose a base branch
from
ygree/fix-llmobs-trace-batching
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+145
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, llm-obs-events-processor only recognized the first trace per request and ignored the rest. Fix sizeInBytes calculation for metrics and logging. Previously, it was the size of the entire buffer rather than of the actual number of bytes for the request
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~7746033211, baseline=1.59.0-SNAPSHOT~189c0b6c76
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.089 s) : 0, 1089404
Total [baseline] (10.779 s) : 0, 10778824
Agent [candidate] (1.089 s) : 0, 1088964
Total [candidate] (10.778 s) : 0, 10777551
section appsec
Agent [baseline] (1.266 s) : 0, 1265810
Total [baseline] (11.058 s) : 0, 11058434
Agent [candidate] (1.267 s) : 0, 1266683
Total [candidate] (11.056 s) : 0, 11055511
section iast
Agent [baseline] (1.223 s) : 0, 1223289
Total [baseline] (11.233 s) : 0, 11232563
Agent [candidate] (1.229 s) : 0, 1228911
Total [candidate] (11.126 s) : 0, 11126143
section profiling
Agent [baseline] (1.202 s) : 0, 1201853
Total [baseline] (10.997 s) : 0, 10997339
Agent [candidate] (1.206 s) : 0, 1205895
Total [candidate] (10.898 s) : 0, 10898397
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~7746033211, baseline=1.59.0-SNAPSHOT~189c0b6c76
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (653.126 ms) : 0, 653126
BytebuddyAgent [candidate] (653.095 ms) : 0, 653095
GlobalTracer [baseline] (284.075 ms) : 0, 284075
GlobalTracer [candidate] (284.352 ms) : 0, 284352
AppSec [baseline] (33.182 ms) : 0, 33182
AppSec [candidate] (32.897 ms) : 0, 32897
Debugger [baseline] (68.659 ms) : 0, 68659
Debugger [candidate] (68.162 ms) : 0, 68162
Remote Config [baseline] (643.425 µs) : 0, 643
Remote Config [candidate] (628.409 µs) : 0, 628
Telemetry [baseline] (9.082 ms) : 0, 9082
Telemetry [candidate] (9.054 ms) : 0, 9054
Flare Poller [baseline] (3.835 ms) : 0, 3835
Flare Poller [candidate] (3.876 ms) : 0, 3876
section appsec
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (691.108 ms) : 0, 691108
BytebuddyAgent [candidate] (691.556 ms) : 0, 691556
GlobalTracer [baseline] (258.503 ms) : 0, 258503
GlobalTracer [candidate] (259.019 ms) : 0, 259019
AppSec [baseline] (172.126 ms) : 0, 172126
AppSec [candidate] (172.756 ms) : 0, 172756
Debugger [baseline] (68.961 ms) : 0, 68961
Debugger [candidate] (67.933 ms) : 0, 67933
Remote Config [baseline] (782.289 µs) : 0, 782
Remote Config [candidate] (797.424 µs) : 0, 797
Telemetry [baseline] (9.344 ms) : 0, 9344
Telemetry [candidate] (9.381 ms) : 0, 9381
Flare Poller [baseline] (3.813 ms) : 0, 3813
Flare Poller [candidate] (3.796 ms) : 0, 3796
IAST [baseline] (24.511 ms) : 0, 24511
IAST [candidate] (24.69 ms) : 0, 24690
section iast
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (789.834 ms) : 0, 789834
BytebuddyAgent [candidate] (794.242 ms) : 0, 794242
GlobalTracer [baseline] (256.003 ms) : 0, 256003
GlobalTracer [candidate] (257.218 ms) : 0, 257218
AppSec [baseline] (34.673 ms) : 0, 34673
AppSec [candidate] (35.413 ms) : 0, 35413
Debugger [baseline] (66.306 ms) : 0, 66306
Debugger [candidate] (65.451 ms) : 0, 65451
Remote Config [baseline] (590.415 µs) : 0, 590
Remote Config [candidate] (567.157 µs) : 0, 567
Telemetry [baseline] (8.629 ms) : 0, 8629
Telemetry [candidate] (8.521 ms) : 0, 8521
Flare Poller [baseline] (3.612 ms) : 0, 3612
Flare Poller [candidate] (3.569 ms) : 0, 3569
IAST [baseline] (27.038 ms) : 0, 27038
IAST [candidate] (27.195 ms) : 0, 27195
section profiling
crashtracking [baseline] (1.215 ms) : 0, 1215
crashtracking [candidate] (1.233 ms) : 0, 1233
BytebuddyAgent [baseline] (700.35 ms) : 0, 700350
BytebuddyAgent [candidate] (702.028 ms) : 0, 702028
GlobalTracer [baseline] (220.595 ms) : 0, 220595
GlobalTracer [candidate] (220.966 ms) : 0, 220966
AppSec [baseline] (32.29 ms) : 0, 32290
AppSec [candidate] (32.26 ms) : 0, 32260
Debugger [baseline] (67.782 ms) : 0, 67782
Debugger [candidate] (68.162 ms) : 0, 68162
Remote Config [baseline] (652.911 µs) : 0, 653
Remote Config [candidate] (670.807 µs) : 0, 671
Telemetry [baseline] (8.93 ms) : 0, 8930
Telemetry [candidate] (8.86 ms) : 0, 8860
Flare Poller [baseline] (3.748 ms) : 0, 3748
Flare Poller [candidate] (3.745 ms) : 0, 3745
ProfilingAgent [baseline] (96.542 ms) : 0, 96542
ProfilingAgent [candidate] (98.051 ms) : 0, 98051
Profiling [baseline] (97.124 ms) : 0, 97124
Profiling [candidate] (98.659 ms) : 0, 98659
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~7746033211, baseline=1.59.0-SNAPSHOT~189c0b6c76
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.087 s) : 0, 1087019
Total [baseline] (8.765 s) : 0, 8764562
Agent [candidate] (1.081 s) : 0, 1080922
Total [candidate] (8.774 s) : 0, 8774166
section iast
Agent [baseline] (1.227 s) : 0, 1226688
Total [baseline] (9.327 s) : 0, 9326551
Agent [candidate] (1.231 s) : 0, 1231391
Total [candidate] (9.377 s) : 0, 9377466
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~7746033211, baseline=1.59.0-SNAPSHOT~189c0b6c76
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (652.244 ms) : 0, 652244
BytebuddyAgent [candidate] (648.975 ms) : 0, 648975
GlobalTracer [baseline] (283.745 ms) : 0, 283745
GlobalTracer [candidate] (282.159 ms) : 0, 282159
AppSec [baseline] (32.824 ms) : 0, 32824
AppSec [candidate] (32.759 ms) : 0, 32759
Debugger [baseline] (67.753 ms) : 0, 67753
Debugger [candidate] (66.975 ms) : 0, 66975
Remote Config [baseline] (653.067 µs) : 0, 653
Remote Config [candidate] (668.06 µs) : 0, 668
Telemetry [baseline] (9.11 ms) : 0, 9110
Telemetry [candidate] (8.919 ms) : 0, 8919
Flare Poller [baseline] (3.855 ms) : 0, 3855
Flare Poller [candidate] (3.814 ms) : 0, 3814
section iast
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (794.576 ms) : 0, 794576
BytebuddyAgent [candidate] (796.408 ms) : 0, 796408
GlobalTracer [baseline] (256.059 ms) : 0, 256059
GlobalTracer [candidate] (258.521 ms) : 0, 258521
AppSec [baseline] (33.626 ms) : 0, 33626
AppSec [candidate] (35.562 ms) : 0, 35562
Debugger [baseline] (65.878 ms) : 0, 65878
Debugger [candidate] (64.154 ms) : 0, 64154
Remote Config [baseline] (600.959 µs) : 0, 601
Remote Config [candidate] (579.007 µs) : 0, 579
Telemetry [baseline] (8.564 ms) : 0, 8564
Telemetry [candidate] (8.554 ms) : 0, 8554
Flare Poller [baseline] (3.619 ms) : 0, 3619
Flare Poller [candidate] (3.62 ms) : 0, 3620
IAST [baseline] (27.033 ms) : 0, 27033
IAST [candidate] (27.27 ms) : 0, 27270
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 17 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~7746033211, baseline=1.59.0-SNAPSHOT~189c0b6c76
dateFormat X
axisFormat %s
section baseline
no_agent (18.106 ms) : 17923, 18290
. : milestone, 18106,
appsec (19.673 ms) : 19471, 19874
. : milestone, 19673,
code_origins (17.914 ms) : 17735, 18094
. : milestone, 17914,
iast (17.742 ms) : 17568, 17916
. : milestone, 17742,
profiling (18.485 ms) : 18298, 18672
. : milestone, 18485,
tracing (17.588 ms) : 17415, 17760
. : milestone, 17588,
section candidate
no_agent (17.273 ms) : 17099, 17447
. : milestone, 17273,
appsec (18.72 ms) : 18532, 18908
. : milestone, 18720,
code_origins (17.942 ms) : 17764, 18120
. : milestone, 17942,
iast (18.071 ms) : 17888, 18253
. : milestone, 18071,
profiling (18.614 ms) : 18428, 18801
. : milestone, 18614,
tracing (17.741 ms) : 17564, 17918
. : milestone, 17741,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~7746033211, baseline=1.59.0-SNAPSHOT~189c0b6c76
dateFormat X
axisFormat %s
section baseline
no_agent (1.19 ms) : 1178, 1202
. : milestone, 1190,
iast (3.319 ms) : 3272, 3367
. : milestone, 3319,
iast_FULL (5.749 ms) : 5692, 5806
. : milestone, 5749,
iast_GLOBAL (3.651 ms) : 3598, 3704
. : milestone, 3651,
profiling (2.084 ms) : 2066, 2102
. : milestone, 2084,
tracing (1.812 ms) : 1796, 1827
. : milestone, 1812,
section candidate
no_agent (1.183 ms) : 1172, 1195
. : milestone, 1183,
iast (3.212 ms) : 3170, 3254
. : milestone, 3212,
iast_FULL (5.926 ms) : 5866, 5986
. : milestone, 5926,
iast_GLOBAL (3.552 ms) : 3495, 3608
. : milestone, 3552,
profiling (1.997 ms) : 1979, 2014
. : milestone, 1997,
tracing (1.789 ms) : 1774, 1804
. : milestone, 1789,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~7746033211, baseline=1.59.0-SNAPSHOT~189c0b6c76
dateFormat X
axisFormat %s
section baseline
no_agent (14.933 s) : 14933000, 14933000
. : milestone, 14933000,
appsec (14.595 s) : 14595000, 14595000
. : milestone, 14595000,
iast (18.219 s) : 18219000, 18219000
. : milestone, 18219000,
iast_GLOBAL (18.045 s) : 18045000, 18045000
. : milestone, 18045000,
profiling (14.718 s) : 14718000, 14718000
. : milestone, 14718000,
tracing (14.711 s) : 14711000, 14711000
. : milestone, 14711000,
section candidate
no_agent (15.434 s) : 15434000, 15434000
. : milestone, 15434000,
appsec (14.533 s) : 14533000, 14533000
. : milestone, 14533000,
iast (17.721 s) : 17721000, 17721000
. : milestone, 17721000,
iast_GLOBAL (17.882 s) : 17882000, 17882000
. : milestone, 17882000,
profiling (14.944 s) : 14944000, 14944000
. : milestone, 14944000,
tracing (14.649 s) : 14649000, 14649000
. : milestone, 14649000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~7746033211, baseline=1.59.0-SNAPSHOT~189c0b6c76
dateFormat X
axisFormat %s
section baseline
no_agent (1.467 ms) : 1456, 1479
. : milestone, 1467,
appsec (3.686 ms) : 3467, 3905
. : milestone, 3686,
iast (2.202 ms) : 2137, 2266
. : milestone, 2202,
iast_GLOBAL (2.244 ms) : 2179, 2308
. : milestone, 2244,
profiling (2.045 ms) : 1994, 2097
. : milestone, 2045,
tracing (2.042 ms) : 1991, 2093
. : milestone, 2042,
section candidate
no_agent (1.468 ms) : 1456, 1479
. : milestone, 1468,
appsec (3.636 ms) : 3422, 3850
. : milestone, 3636,
iast (2.205 ms) : 2140, 2269
. : milestone, 2205,
iast_GLOBAL (2.248 ms) : 2183, 2314
. : milestone, 2248,
profiling (2.455 ms) : 2297, 2614
. : milestone, 2455,
tracing (2.034 ms) : 1983, 2085
. : milestone, 2034,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Fix sending multiple LLM Obs traces per request.
Previously, llm-obs-events-processor only recognized the first trace per request and ignored the rest.
Fix sizeInBytes calculation for metrics and logging.
Previously, it was the size of the entire buffer rather than of the actual number of bytes for the request
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]