-
Notifications
You must be signed in to change notification settings - Fork 324
Fixed NPE in graphql exception unwrapper #10459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
approved these changes
Jan 28, 2026
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~c9d451437d, baseline=1.59.0-SNAPSHOT~c53c2c595e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1056918
Total [baseline] (8.704 s) : 0, 8703902
Agent [candidate] (1.059 s) : 0, 1058830
Total [candidate] (8.7 s) : 0, 8699814
section iast
Agent [baseline] (1.235 s) : 0, 1235362
Total [baseline] (9.363 s) : 0, 9362957
Agent [candidate] (1.234 s) : 0, 1234248
Total [candidate] (9.41 s) : 0, 9410411
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~c9d451437d, baseline=1.59.0-SNAPSHOT~c53c2c595e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.175 ms) : 0, 1175
crashtracking [candidate] (1.177 ms) : 0, 1177
BytebuddyAgent [baseline] (622.338 ms) : 0, 622338
BytebuddyAgent [candidate] (624.211 ms) : 0, 624211
AgentMeter [baseline] (28.658 ms) : 0, 28658
AgentMeter [candidate] (28.647 ms) : 0, 28647
GlobalTracer [baseline] (256.148 ms) : 0, 256148
GlobalTracer [candidate] (257.2 ms) : 0, 257200
AppSec [baseline] (32.644 ms) : 0, 32644
AppSec [candidate] (32.908 ms) : 0, 32908
Debugger [baseline] (60.818 ms) : 0, 60818
Debugger [candidate] (61.179 ms) : 0, 61179
Remote Config [baseline] (623.919 µs) : 0, 624
Remote Config [candidate] (615.713 µs) : 0, 616
Telemetry [baseline] (9.882 ms) : 0, 9882
Telemetry [candidate] (9.062 ms) : 0, 9062
Flare Poller [baseline] (9.142 ms) : 0, 9142
Flare Poller [candidate] (8.398 ms) : 0, 8398
section iast
crashtracking [baseline] (1.205 ms) : 0, 1205
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (799.35 ms) : 0, 799350
BytebuddyAgent [candidate] (798.491 ms) : 0, 798491
AgentMeter [baseline] (11.347 ms) : 0, 11347
AgentMeter [candidate] (11.382 ms) : 0, 11382
GlobalTracer [baseline] (248.888 ms) : 0, 248888
GlobalTracer [candidate] (248.949 ms) : 0, 248949
IAST [baseline] (27.053 ms) : 0, 27053
IAST [candidate] (26.968 ms) : 0, 26968
AppSec [baseline] (33.487 ms) : 0, 33487
AppSec [candidate] (33.656 ms) : 0, 33656
Debugger [baseline] (65.859 ms) : 0, 65859
Debugger [candidate] (65.516 ms) : 0, 65516
Remote Config [baseline] (539.681 µs) : 0, 540
Remote Config [candidate] (556.635 µs) : 0, 557
Telemetry [baseline] (8.559 ms) : 0, 8559
Telemetry [candidate] (8.547 ms) : 0, 8547
Flare Poller [baseline] (3.479 ms) : 0, 3479
Flare Poller [candidate] (3.471 ms) : 0, 3471
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~c9d451437d, baseline=1.59.0-SNAPSHOT~c53c2c595e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1057287
Total [baseline] (10.977 s) : 0, 10976521
Agent [candidate] (1.059 s) : 0, 1058884
Total [candidate] (10.962 s) : 0, 10962489
section appsec
Agent [baseline] (1.232 s) : 0, 1232256
Total [baseline] (10.992 s) : 0, 10992302
Agent [candidate] (1.233 s) : 0, 1232516
Total [candidate] (10.971 s) : 0, 10971493
section iast
Agent [baseline] (1.23 s) : 0, 1229546
Total [baseline] (11.191 s) : 0, 11190886
Agent [candidate] (1.223 s) : 0, 1223083
Total [candidate] (11.103 s) : 0, 11102568
section profiling
Agent [baseline] (1.19 s) : 0, 1190085
Total [baseline] (10.923 s) : 0, 10922696
Agent [candidate] (1.187 s) : 0, 1186944
Total [candidate] (11.008 s) : 0, 11007607
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~c9d451437d, baseline=1.59.0-SNAPSHOT~c53c2c595e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.172 ms) : 0, 1172
BytebuddyAgent [baseline] (622.679 ms) : 0, 622679
BytebuddyAgent [candidate] (623.178 ms) : 0, 623178
AgentMeter [baseline] (28.699 ms) : 0, 28699
AgentMeter [candidate] (28.7 ms) : 0, 28700
GlobalTracer [baseline] (257.335 ms) : 0, 257335
GlobalTracer [candidate] (257.561 ms) : 0, 257561
AppSec [baseline] (32.866 ms) : 0, 32866
AppSec [candidate] (32.927 ms) : 0, 32927
Debugger [baseline] (61.184 ms) : 0, 61184
Debugger [candidate] (63.358 ms) : 0, 63358
Remote Config [baseline] (627.263 µs) : 0, 627
Remote Config [candidate] (635.502 µs) : 0, 636
Telemetry [baseline] (9.851 ms) : 0, 9851
Telemetry [candidate] (9.217 ms) : 0, 9217
Flare Poller [baseline] (7.526 ms) : 0, 7526
Flare Poller [candidate] (6.843 ms) : 0, 6843
section appsec
crashtracking [baseline] (1.178 ms) : 0, 1178
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (652.778 ms) : 0, 652778
BytebuddyAgent [candidate] (652.178 ms) : 0, 652178
AgentMeter [baseline] (11.845 ms) : 0, 11845
AgentMeter [candidate] (11.854 ms) : 0, 11854
GlobalTracer [baseline] (257.471 ms) : 0, 257471
GlobalTracer [candidate] (257.715 ms) : 0, 257715
IAST [baseline] (25.353 ms) : 0, 25353
IAST [candidate] (25.353 ms) : 0, 25353
AppSec [baseline] (167.174 ms) : 0, 167174
AppSec [candidate] (167.759 ms) : 0, 167759
Debugger [baseline] (67.433 ms) : 0, 67433
Debugger [candidate] (67.535 ms) : 0, 67535
Remote Config [baseline] (663.692 µs) : 0, 664
Remote Config [candidate] (661.327 µs) : 0, 661
Telemetry [baseline] (9.274 ms) : 0, 9274
Telemetry [candidate] (9.272 ms) : 0, 9272
Flare Poller [baseline] (3.728 ms) : 0, 3728
Flare Poller [candidate] (3.664 ms) : 0, 3664
section iast
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.17 ms) : 0, 1170
BytebuddyAgent [baseline] (792.476 ms) : 0, 792476
BytebuddyAgent [candidate] (787.974 ms) : 0, 787974
AgentMeter [baseline] (11.163 ms) : 0, 11163
AgentMeter [candidate] (11.112 ms) : 0, 11112
GlobalTracer [baseline] (248.918 ms) : 0, 248918
GlobalTracer [candidate] (247.398 ms) : 0, 247398
IAST [baseline] (26.967 ms) : 0, 26967
IAST [candidate] (27.059 ms) : 0, 27059
AppSec [baseline] (33.911 ms) : 0, 33911
AppSec [candidate] (33.648 ms) : 0, 33648
Debugger [baseline] (66.796 ms) : 0, 66796
Debugger [candidate] (66.844 ms) : 0, 66844
Remote Config [baseline] (543.701 µs) : 0, 544
Remote Config [candidate] (553.332 µs) : 0, 553
Telemetry [baseline] (8.691 ms) : 0, 8691
Telemetry [candidate] (8.535 ms) : 0, 8535
Flare Poller [baseline] (3.523 ms) : 0, 3523
Flare Poller [candidate] (3.493 ms) : 0, 3493
section profiling
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.211 ms) : 0, 1211
BytebuddyAgent [baseline] (679.502 ms) : 0, 679502
BytebuddyAgent [candidate] (676.904 ms) : 0, 676904
AgentMeter [baseline] (8.609 ms) : 0, 8609
AgentMeter [candidate] (8.596 ms) : 0, 8596
GlobalTracer [baseline] (217.282 ms) : 0, 217282
GlobalTracer [candidate] (216.908 ms) : 0, 216908
AppSec [baseline] (32.607 ms) : 0, 32607
AppSec [candidate] (32.294 ms) : 0, 32294
Debugger [baseline] (67.964 ms) : 0, 67964
Debugger [candidate] (67.803 ms) : 0, 67803
Remote Config [baseline] (597.854 µs) : 0, 598
Remote Config [candidate] (600.596 µs) : 0, 601
Telemetry [baseline] (8.775 ms) : 0, 8775
Telemetry [candidate] (8.75 ms) : 0, 8750
Flare Poller [baseline] (3.793 ms) : 0, 3793
Flare Poller [candidate] (3.806 ms) : 0, 3806
ProfilingAgent [baseline] (99.751 ms) : 0, 99751
ProfilingAgent [candidate] (100.248 ms) : 0, 100248
Profiling [baseline] (100.333 ms) : 0, 100333
Profiling [candidate] (100.823 ms) : 0, 100823
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 17 metrics, 18 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~c9d451437d, baseline=1.59.0-SNAPSHOT~c53c2c595e
dateFormat X
axisFormat %s
section baseline
no_agent (1.196 ms) : 1184, 1208
. : milestone, 1196,
iast (3.291 ms) : 3246, 3336
. : milestone, 3291,
iast_FULL (5.575 ms) : 5520, 5629
. : milestone, 5575,
iast_GLOBAL (3.517 ms) : 3455, 3578
. : milestone, 3517,
profiling (2.083 ms) : 2064, 2103
. : milestone, 2083,
tracing (1.793 ms) : 1779, 1807
. : milestone, 1793,
section candidate
no_agent (1.2 ms) : 1188, 1212
. : milestone, 1200,
iast (3.246 ms) : 3203, 3288
. : milestone, 3246,
iast_FULL (5.757 ms) : 5699, 5814
. : milestone, 5757,
iast_GLOBAL (3.403 ms) : 3354, 3451
. : milestone, 3403,
profiling (2.038 ms) : 2020, 2057
. : milestone, 2038,
tracing (1.79 ms) : 1775, 1805
. : milestone, 1790,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~c9d451437d, baseline=1.59.0-SNAPSHOT~c53c2c595e
dateFormat X
axisFormat %s
section baseline
no_agent (19.282 ms) : 19087, 19477
. : milestone, 19282,
appsec (18.866 ms) : 18675, 19056
. : milestone, 18866,
code_origins (17.597 ms) : 17423, 17770
. : milestone, 17597,
iast (17.899 ms) : 17717, 18081
. : milestone, 17899,
profiling (18.765 ms) : 18580, 18950
. : milestone, 18765,
tracing (17.629 ms) : 17455, 17803
. : milestone, 17629,
section candidate
no_agent (18.331 ms) : 18138, 18524
. : milestone, 18331,
appsec (19.838 ms) : 19635, 20040
. : milestone, 19838,
code_origins (17.687 ms) : 17510, 17863
. : milestone, 17687,
iast (17.58 ms) : 17407, 17752
. : milestone, 17580,
profiling (18.424 ms) : 18241, 18606
. : milestone, 18424,
tracing (17.644 ms) : 17467, 17821
. : milestone, 17644,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~c9d451437d, baseline=1.59.0-SNAPSHOT~c53c2c595e
dateFormat X
axisFormat %s
section baseline
no_agent (15.052 s) : 15052000, 15052000
. : milestone, 15052000,
appsec (14.878 s) : 14878000, 14878000
. : milestone, 14878000,
iast (17.93 s) : 17930000, 17930000
. : milestone, 17930000,
iast_GLOBAL (18.096 s) : 18096000, 18096000
. : milestone, 18096000,
profiling (14.929 s) : 14929000, 14929000
. : milestone, 14929000,
tracing (14.698 s) : 14698000, 14698000
. : milestone, 14698000,
section candidate
no_agent (15.616 s) : 15616000, 15616000
. : milestone, 15616000,
appsec (15.113 s) : 15113000, 15113000
. : milestone, 15113000,
iast (18.49 s) : 18490000, 18490000
. : milestone, 18490000,
iast_GLOBAL (17.913 s) : 17913000, 17913000
. : milestone, 17913000,
profiling (14.946 s) : 14946000, 14946000
. : milestone, 14946000,
tracing (14.688 s) : 14688000, 14688000
. : milestone, 14688000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~c9d451437d, baseline=1.59.0-SNAPSHOT~c53c2c595e
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1487
. : milestone, 1475,
appsec (3.677 ms) : 3458, 3896
. : milestone, 3677,
iast (2.251 ms) : 2183, 2320
. : milestone, 2251,
iast_GLOBAL (2.292 ms) : 2222, 2361
. : milestone, 2292,
profiling (2.106 ms) : 2050, 2163
. : milestone, 2106,
tracing (2.05 ms) : 1997, 2104
. : milestone, 2050,
section candidate
no_agent (1.468 ms) : 1457, 1479
. : milestone, 1468,
appsec (3.691 ms) : 3474, 3907
. : milestone, 3691,
iast (2.254 ms) : 2185, 2323
. : milestone, 2254,
iast_GLOBAL (2.293 ms) : 2224, 2362
. : milestone, 2293,
profiling (2.09 ms) : 2035, 2145
. : milestone, 2090,
tracing (2.058 ms) : 2004, 2111
. : milestone, 2058,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
inst: graphql
GraphQL instrumentation
tag: no release notes
Changes to exclude from release notes
type: bug
Bug report and fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
NPE fix for #10389
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]