Migrate dd-trace-core groovy files to java part 1#11053
Migrate dd-trace-core groovy files to java part 1#11053gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom
Conversation
Migrate dd-trace-core module from Groovy to Java, using the /migrate-groovy-to-java Claude skill. This is part 1 with five file changes with no dependencies.
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
| // This fails because RemoteWriter isn't an interface and the mock doesn't prevent the call. | ||
| @Ignore | ||
| def "test onStart"() { | ||
| setup: | ||
| def writer = Mock(RemoteWriter) | ||
| def capacity = ThreadLocalRandom.current().nextInt() | ||
|
|
||
| when: | ||
| healthMetrics.onStart(writer) | ||
|
|
||
| then: | ||
| 1 * writer.getCapacity() >> capacity | ||
| 0 * _ | ||
| } |
There was a problem hiding this comment.
this test was removed during the migration. This test as been silented for 6 years now.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~e065d52b3d, baseline=1.61.0-SNAPSHOT~cd5b227eb2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1067052
Total [baseline] (8.837 s) : 0, 8837358
Agent [candidate] (1.057 s) : 0, 1057311
Total [candidate] (8.832 s) : 0, 8831598
section iast
Agent [baseline] (1.22 s) : 0, 1220239
Total [baseline] (9.547 s) : 0, 9546512
Agent [candidate] (1.224 s) : 0, 1223577
Total [candidate] (9.529 s) : 0, 9528942
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~e065d52b3d, baseline=1.61.0-SNAPSHOT~cd5b227eb2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.212 ms) : 0, 1212
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (641.05 ms) : 0, 641050
BytebuddyAgent [candidate] (633.358 ms) : 0, 633358
AgentMeter [baseline] (29.797 ms) : 0, 29797
AgentMeter [candidate] (29.426 ms) : 0, 29426
GlobalTracer [baseline] (251.522 ms) : 0, 251522
GlobalTracer [candidate] (248.993 ms) : 0, 248993
AppSec [baseline] (32.376 ms) : 0, 32376
AppSec [candidate] (32.01 ms) : 0, 32010
Debugger [baseline] (60.009 ms) : 0, 60009
Debugger [candidate] (59.335 ms) : 0, 59335
Remote Config [baseline] (614.529 µs) : 0, 615
Remote Config [candidate] (594.755 µs) : 0, 595
Telemetry [baseline] (8.205 ms) : 0, 8205
Telemetry [candidate] (8.034 ms) : 0, 8034
Flare Poller [baseline] (5.841 ms) : 0, 5841
Flare Poller [candidate] (8.169 ms) : 0, 8169
section iast
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (799.447 ms) : 0, 799447
BytebuddyAgent [candidate] (801.284 ms) : 0, 801284
AgentMeter [baseline] (11.383 ms) : 0, 11383
AgentMeter [candidate] (11.364 ms) : 0, 11364
GlobalTracer [baseline] (237.826 ms) : 0, 237826
GlobalTracer [candidate] (238.818 ms) : 0, 238818
IAST [baseline] (25.818 ms) : 0, 25818
IAST [candidate] (25.883 ms) : 0, 25883
AppSec [baseline] (30.707 ms) : 0, 30707
AppSec [candidate] (27.159 ms) : 0, 27159
Debugger [baseline] (58.357 ms) : 0, 58357
Debugger [candidate] (62.211 ms) : 0, 62211
Remote Config [baseline] (539.939 µs) : 0, 540
Remote Config [candidate] (522.443 µs) : 0, 522
Telemetry [baseline] (13.717 ms) : 0, 13717
Telemetry [candidate] (14.504 ms) : 0, 14504
Flare Poller [baseline] (4.402 ms) : 0, 4402
Flare Poller [candidate] (4.305 ms) : 0, 4305
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~e065d52b3d, baseline=1.61.0-SNAPSHOT~cd5b227eb2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056296
Total [baseline] (11.121 s) : 0, 11120926
Agent [candidate] (1.058 s) : 0, 1057968
Total [candidate] (11.093 s) : 0, 11092823
section appsec
Agent [baseline] (1.253 s) : 0, 1252851
Total [baseline] (11.253 s) : 0, 11252755
Agent [candidate] (1.251 s) : 0, 1251000
Total [candidate] (11.131 s) : 0, 11131214
section iast
Agent [baseline] (1.225 s) : 0, 1224916
Total [baseline] (11.288 s) : 0, 11287925
Agent [candidate] (1.224 s) : 0, 1224206
Total [candidate] (11.295 s) : 0, 11295302
section profiling
Agent [baseline] (1.186 s) : 0, 1186216
Total [baseline] (11.046 s) : 0, 11045739
Agent [candidate] (1.182 s) : 0, 1182150
Total [candidate] (11.073 s) : 0, 11073488
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~e065d52b3d, baseline=1.61.0-SNAPSHOT~cd5b227eb2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.207 ms) : 0, 1207
BytebuddyAgent [baseline] (632.942 ms) : 0, 632942
BytebuddyAgent [candidate] (631.994 ms) : 0, 631994
AgentMeter [baseline] (29.634 ms) : 0, 29634
AgentMeter [candidate] (29.528 ms) : 0, 29528
GlobalTracer [baseline] (249.449 ms) : 0, 249449
GlobalTracer [candidate] (249.487 ms) : 0, 249487
AppSec [baseline] (32.11 ms) : 0, 32110
AppSec [candidate] (32.252 ms) : 0, 32252
Debugger [baseline] (60.098 ms) : 0, 60098
Debugger [candidate] (60.532 ms) : 0, 60532
Remote Config [baseline] (600.254 µs) : 0, 600
Remote Config [candidate] (603.424 µs) : 0, 603
Telemetry [baseline] (8.057 ms) : 0, 8057
Telemetry [candidate] (8.109 ms) : 0, 8109
Flare Poller [baseline] (5.921 ms) : 0, 5921
Flare Poller [candidate] (8.131 ms) : 0, 8131
section appsec
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (666.371 ms) : 0, 666371
BytebuddyAgent [candidate] (665.698 ms) : 0, 665698
AgentMeter [baseline] (12.131 ms) : 0, 12131
AgentMeter [candidate] (12.118 ms) : 0, 12118
GlobalTracer [baseline] (249.498 ms) : 0, 249498
GlobalTracer [candidate] (248.795 ms) : 0, 248795
IAST [baseline] (24.464 ms) : 0, 24464
IAST [candidate] (24.521 ms) : 0, 24521
AppSec [baseline] (183.793 ms) : 0, 183793
AppSec [candidate] (183.197 ms) : 0, 183197
Debugger [baseline] (66.308 ms) : 0, 66308
Debugger [candidate] (66.256 ms) : 0, 66256
Remote Config [baseline] (604.972 µs) : 0, 605
Remote Config [candidate] (622.6 µs) : 0, 623
Telemetry [baseline] (8.458 ms) : 0, 8458
Telemetry [candidate] (8.619 ms) : 0, 8619
Flare Poller [baseline] (3.517 ms) : 0, 3517
Flare Poller [candidate] (3.554 ms) : 0, 3554
section iast
crashtracking [baseline] (1.207 ms) : 0, 1207
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (801.62 ms) : 0, 801620
BytebuddyAgent [candidate] (801.334 ms) : 0, 801334
AgentMeter [baseline] (11.404 ms) : 0, 11404
AgentMeter [candidate] (11.382 ms) : 0, 11382
GlobalTracer [baseline] (239.06 ms) : 0, 239060
GlobalTracer [candidate] (238.939 ms) : 0, 238939
IAST [baseline] (25.85 ms) : 0, 25850
IAST [candidate] (25.711 ms) : 0, 25711
AppSec [baseline] (30.855 ms) : 0, 30855
AppSec [candidate] (31.664 ms) : 0, 31664
Debugger [baseline] (59.302 ms) : 0, 59302
Debugger [candidate] (58.469 ms) : 0, 58469
Remote Config [baseline] (520.96 µs) : 0, 521
Remote Config [candidate] (513.405 µs) : 0, 513
Telemetry [baseline] (14.625 ms) : 0, 14625
Telemetry [candidate] (14.459 ms) : 0, 14459
Flare Poller [baseline] (3.628 ms) : 0, 3628
Flare Poller [candidate] (4.08 ms) : 0, 4080
section profiling
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.168 ms) : 0, 1168
BytebuddyAgent [baseline] (693.426 ms) : 0, 693426
BytebuddyAgent [candidate] (689.9 ms) : 0, 689900
AgentMeter [baseline] (9.135 ms) : 0, 9135
AgentMeter [candidate] (9.114 ms) : 0, 9114
GlobalTracer [baseline] (207.047 ms) : 0, 207047
GlobalTracer [candidate] (206.89 ms) : 0, 206890
AppSec [baseline] (32.612 ms) : 0, 32612
AppSec [candidate] (32.564 ms) : 0, 32564
Debugger [baseline] (65.086 ms) : 0, 65086
Debugger [candidate] (65.569 ms) : 0, 65569
Remote Config [baseline] (570.647 µs) : 0, 571
Remote Config [candidate] (573.775 µs) : 0, 574
Telemetry [baseline] (8.621 ms) : 0, 8621
Telemetry [candidate] (7.931 ms) : 0, 7931
Flare Poller [baseline] (3.581 ms) : 0, 3581
Flare Poller [candidate] (3.609 ms) : 0, 3609
ProfilingAgent [baseline] (93.57 ms) : 0, 93570
ProfilingAgent [candidate] (93.673 ms) : 0, 93673
Profiling [baseline] (94.133 ms) : 0, 94133
Profiling [candidate] (94.237 ms) : 0, 94237
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 0 performance regressions! Performance is the same for 15 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~e065d52b3d, baseline=1.61.0-SNAPSHOT~cd5b227eb2
dateFormat X
axisFormat %s
section baseline
no_agent (18.358 ms) : 18166, 18549
. : milestone, 18358,
appsec (20.644 ms) : 20433, 20855
. : milestone, 20644,
code_origins (17.641 ms) : 17468, 17814
. : milestone, 17641,
iast (17.863 ms) : 17683, 18044
. : milestone, 17863,
profiling (18.661 ms) : 18476, 18845
. : milestone, 18661,
tracing (17.663 ms) : 17487, 17838
. : milestone, 17663,
section candidate
no_agent (17.955 ms) : 17776, 18133
. : milestone, 17955,
appsec (18.706 ms) : 18515, 18897
. : milestone, 18706,
code_origins (17.711 ms) : 17535, 17888
. : milestone, 17711,
iast (17.904 ms) : 17729, 18079
. : milestone, 17904,
profiling (18.563 ms) : 18379, 18746
. : milestone, 18563,
tracing (17.77 ms) : 17597, 17943
. : milestone, 17770,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~e065d52b3d, baseline=1.61.0-SNAPSHOT~cd5b227eb2
dateFormat X
axisFormat %s
section baseline
no_agent (1.254 ms) : 1242, 1267
. : milestone, 1254,
iast (3.464 ms) : 3428, 3500
. : milestone, 3464,
iast_FULL (6.013 ms) : 5952, 6074
. : milestone, 6013,
iast_GLOBAL (3.636 ms) : 3573, 3699
. : milestone, 3636,
profiling (2.499 ms) : 2468, 2531
. : milestone, 2499,
tracing (1.864 ms) : 1848, 1879
. : milestone, 1864,
section candidate
no_agent (1.254 ms) : 1242, 1267
. : milestone, 1254,
iast (3.393 ms) : 3351, 3434
. : milestone, 3393,
iast_FULL (6.256 ms) : 6191, 6320
. : milestone, 6256,
iast_GLOBAL (3.509 ms) : 3451, 3566
. : milestone, 3509,
profiling (2.244 ms) : 2223, 2265
. : milestone, 2244,
tracing (1.903 ms) : 1887, 1919
. : milestone, 1903,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~e065d52b3d, baseline=1.61.0-SNAPSHOT~cd5b227eb2
dateFormat X
axisFormat %s
section baseline
no_agent (14.716 s) : 14716000, 14716000
. : milestone, 14716000,
appsec (14.814 s) : 14814000, 14814000
. : milestone, 14814000,
iast (18.485 s) : 18485000, 18485000
. : milestone, 18485000,
iast_GLOBAL (17.53 s) : 17530000, 17530000
. : milestone, 17530000,
profiling (14.921 s) : 14921000, 14921000
. : milestone, 14921000,
tracing (14.754 s) : 14754000, 14754000
. : milestone, 14754000,
section candidate
no_agent (15.039 s) : 15039000, 15039000
. : milestone, 15039000,
appsec (14.936 s) : 14936000, 14936000
. : milestone, 14936000,
iast (18.609 s) : 18609000, 18609000
. : milestone, 18609000,
iast_GLOBAL (18.146 s) : 18146000, 18146000
. : milestone, 18146000,
profiling (14.903 s) : 14903000, 14903000
. : milestone, 14903000,
tracing (15.109 s) : 15109000, 15109000
. : milestone, 15109000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~e065d52b3d, baseline=1.61.0-SNAPSHOT~cd5b227eb2
dateFormat X
axisFormat %s
section baseline
no_agent (1.491 ms) : 1479, 1503
. : milestone, 1491,
appsec (3.816 ms) : 3593, 4040
. : milestone, 3816,
iast (2.287 ms) : 2218, 2357
. : milestone, 2287,
iast_GLOBAL (2.317 ms) : 2247, 2386
. : milestone, 2317,
profiling (2.107 ms) : 2052, 2162
. : milestone, 2107,
tracing (2.088 ms) : 2034, 2142
. : milestone, 2088,
section candidate
no_agent (1.495 ms) : 1483, 1506
. : milestone, 1495,
appsec (3.829 ms) : 3606, 4051
. : milestone, 3829,
iast (2.283 ms) : 2214, 2352
. : milestone, 2283,
iast_GLOBAL (2.327 ms) : 2257, 2397
. : milestone, 2327,
profiling (2.131 ms) : 2074, 2187
. : milestone, 2131,
tracing (2.083 ms) : 2030, 2136
. : milestone, 2083,
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
Migrate
dd-trace-coremodule from Groovy to Java, using the /migrate-groovy-to-java Claude skill. This is part 1 with five file changes with no dependencies.Motivation
this is part of the effort to migrate groovy tests to Java/JUnit
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.